When a pending contents is created but deleted before it is shown, remove it from the list of pendi…

content/browser/web_contents/web_contents_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/test_render_view_host.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/web_contents/interstitial_page_impl.h"
@@ skipping 2019 matching lines @@
       static_cast<TestWebContents*>(CreateTestWebContents()));
   TestWebContentsObserver other_observer(other_contents.get());
   other_contents->NavigateAndCommit(url_normalized);
 
   // Check that an IPC with about:whatever is correctly normalized.
   other_contents->TestDidFailLoadWithError(
       1, url_from_ipc, true, 1, string16());
   EXPECT_EQ(url_normalized, other_observer.last_url());
 }
 
+// Test that a if a pending contents is deleted before it is shown, we don't

[Charlie Reis, 2013/03/07 22:01:02]

typo: that a if a

+// crash.
+TEST_F(WebContentsImplTest, PendingContents) {
+  scoped_ptr<TestWebContents> other_contents(
+      static_cast<TestWebContents*>(CreateTestWebContents()));
+  contents()->AddPendingContents(other_contents.get());
+  int route_id = other_contents->GetRenderViewHost()->GetRoutingID();
+  other_contents.reset();
+  EXPECT_EQ(NULL, contents()->GetCreatedWindow(route_id));
+}
 
 }  // namespace content