Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: content/browser/permissions/permission_pending_single_request.h

Issue 1260193009: renderer: implement multiple permission requesting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions-request-multiple
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/permissions/permission_pending_single_request.h
diff --git a/content/browser/permissions/permission_pending_single_request.h b/content/browser/permissions/permission_pending_single_request.h
new file mode 100644
index 0000000000000000000000000000000000000000..74654e8f4daca43c26007abf2fc28e581a43430f
--- /dev/null
+++ b/content/browser/permissions/permission_pending_single_request.h
@@ -0,0 +1,44 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_PERMISSIONS_PERMISSION_PENDING_SINGLE_REQUEST_H_
+#define CONTENT_BROWSER_PERMISSIONS_PERMISSION_PENDING_SINGLE_REQUEST_H_
+
+#include "base/callback_forward.h"
+#include "base/macros.h"
+#include "content/browser/permissions/permission_pending_request.h"
+#include "content/common/permission_service.mojom.h"
+#include "third_party/mojo/src/mojo/public/cpp/bindings/binding.h"
+#include "url/gurl.h"
+
+namespace content {
+
+enum class PermissionType;
+
+class PermissionPendingSingleRequest : public PermissionPendingRequest {
mlamouri (slow - plz ping) 2015/08/18 13:37:15 Could that be simplified to be a special case of m
Lalit Maganti 2015/08/20 14:23:30 I'm split about this. It would vastly reduce code
+ public:
+ using PermissionStatusCallback = mojo::Callback<void(PermissionStatus)>;
+
+ PermissionPendingSingleRequest(
+ PermissionType permission,
+ const GURL& origin,
+ const PermissionStatusCallback& callback);
+ ~PermissionPendingSingleRequest() override;
+
+ void Cancel(PermissionManager* permission_manager,
+ RenderFrameHost* context,
+ int request_id) override;
+
+ PermissionStatusCallback callback;
+
+ private:
+ PermissionType permission;
+ GURL origin;
+
+ DISALLOW_COPY_AND_ASSIGN(PermissionPendingSingleRequest);
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_PERMISSIONS_PERMISSION_PENDING_SINGLE_REQUEST_H_

Powered by Google App Engine
This is Rietveld 408576698