renderer: implement multiple permission requesting

content/shell/browser/layout_test/layout_test_permission_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/browser/layout_test/layout_test_permission_manager.h"
 
 #include <list>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 49 matching lines @@
 
 LayoutTestPermissionManager::~LayoutTestPermissionManager() {
 }
 
 void LayoutTestPermissionManager::RequestPermission(
     PermissionType permission,
     RenderFrameHost* render_frame_host,
     int request_id,
     const GURL& requesting_origin,
     bool user_gesture,
-    const base::Callback<void(PermissionStatus)>& callback) {
+    const RequestCallback& callback) {

[mlamouri (slow - plz ping), 2015/09/02 11:36:42]

nit: keep the plain callback type.

[Lalit Maganti, 2015/09/02 14:24:51]

Done.

   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   callback.Run(GetPermissionStatus(
       permission, requesting_origin,
       WebContents::FromRenderFrameHost(render_frame_host)
           ->GetLastCommittedURL().GetOrigin()));
 }
 
+void LayoutTestPermissionManager::RequestPermission(
+    const std::vector<PermissionType>& permissions,
+    content::RenderFrameHost* render_frame_host,
+    int request_id,
+    const GURL& requesting_origin,
+    bool user_gesture,
+    const BatchRequestCallback& callback) {
+  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+
+  std::vector<PermissionStatus> statuses(

[mlamouri (slow - plz ping), 2015/09/02 11:36:42]

nit: if you want, you can rename statuses to result.

[Lalit Maganti, 2015/09/02 14:24:51]

Done.

+    permissions.size(), PERMISSION_STATUS_DENIED);
+  for (size_t i = 0; i < permissions.size(); i++) {

[mlamouri (slow - plz ping), 2015/09/02 11:36:42]

nit: you can probably do something among those lines:

for (const auto& permission : permissions) {
  result.push_back(GetPermissionStatus(permission, requesting_origin,
WebContents::...());
}

+    statuses[i] = GetPermissionStatus(
+        permissions[i], requesting_origin,
+        WebContents::FromRenderFrameHost(render_frame_host)
+            ->GetLastCommittedURL().GetOrigin());
+  }
+  callback.Run(statuses);
+}
+
 void LayoutTestPermissionManager::CancelPermissionRequest(
-    PermissionType permission,
     RenderFrameHost* render_frame_host,
-    int request_id,
-    const GURL& requesting_origin) {
+    int request_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 }
 
 void LayoutTestPermissionManager::ResetPermission(
     PermissionType permission,
     const GURL& requesting_origin,
     const GURL& embedding_origin) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   base::AutoLock lock(permissions_lock_);
@@ skipping 102 matching lines @@
     // Add the callback to |callbacks| which will be run after the loop to
     // prevent re-entrance issues.
     callbacks.push_back(base::Bind(subscription->callback, status));
   }
 
   for (const auto& callback : callbacks)
     callback.Run();
 }
 
 }  // namespace content