renderer: implement multiple permission requesting

content/public/browser/permission_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_PERMISSION_MANAGER_H_
 #define CONTENT_PUBLIC_BROWSER_PERMISSION_MANAGER_H_
 
 #include "content/common/content_export.h"
 #include "content/public/common/permission_status.mojom.h"
 
 class GURL;
 
 namespace content {
 enum class PermissionType;
 class RenderFrameHost;
 
 // This class allows the content layer to manipulate permissions. It has to be
 // implemented by the embedder which ultimately handles the permission
 // management for the content layer.
 class CONTENT_EXPORT PermissionManager {
  public:
   virtual ~PermissionManager() = default;
+  using RequestCallback = base::Callback<void(PermissionStatus)>;
+  using BatchRequestCallback =

[mlamouri (slow - plz ping), 2015/09/02 11:36:41]

Let's drop "Batch" has a name. It's really odd.

Also, could you remove the using from the public space of the class?

[Lalit Maganti, 2015/09/02 14:24:51]

Done.

+      base::Callback<void(const std::vector<PermissionStatus>&)>;
 
   // Requests a permission on behalf of a frame identified by render_frame_host.
   // The |request_id| is an identifier that can later be used if the request is
   // cancelled (see CancelPermissionRequest).
   // When the permission request is handled, whether it failed, timed out or
   // succeeded, the |callback| will be run.
   virtual void RequestPermission(
       PermissionType permission,
       RenderFrameHost* render_frame_host,
       int request_id,
       const GURL& requesting_origin,
       bool user_gesture,
-      const base::Callback<void(PermissionStatus)>& callback) = 0;
+      const RequestCallback& callback) = 0;
+
+  // Requests multiple permissions on behalf of a frame identified by
+  // render_frame_host.
+  // The |request_id| is an identifier that can later be used if the request is
+  // cancelled (see CancelPermissionRequest).
+  // When the permission request is handled, whether it failed, timed out or
+  // succeeded, the |callback| will be run.
+  virtual void RequestPermission(

[mlamouri (slow - plz ping), 2015/09/02 11:36:41]

I would tend to say that you can add an 's' here. I know the name difference is
subtle but one method takes a vector<> and not the other so callers shouldn't be
mistaken.

Ideally, both should be named "Request()" but that's not going to happen ;)

[Lalit Maganti, 2015/09/02 14:24:51]

Done.

+      const std::vector<PermissionType>& permission,
+      RenderFrameHost* render_frame_host,
+      int request_id,
+      const GURL& requesting_origin,
+      bool user_gesture,
+      const BatchRequestCallback& callback) = 0;
 
   // Cancels a previously requested permission. The given parameter must match
-  // the ones passed to the RequestPermission call.
-  virtual void CancelPermissionRequest(PermissionType permission,
-                                       RenderFrameHost* render_frame_host,
-                                       int request_id,
-                                       const GURL& requesting_origin) = 0;
+  // the ones passed to a RequestPermission call.
+  virtual void CancelPermissionRequest(RenderFrameHost* render_frame_host,
+                                       int request_id) = 0;
 
   // Returns the permission status of a given requesting_origin/embedding_origin
   // tuple. This is not taking a RenderFrameHost because the call might happen
   // outside of a frame context.
   virtual PermissionStatus GetPermissionStatus(
       PermissionType permission,
       const GURL& requesting_origin,
       const GURL& embedding_origin) = 0;
 
   // Sets the permission back to its default for the requesting_origin/
@@ skipping 19 matching lines @@
 
   // Unregisters from permission status change notifications.
   // The |subscription_id| must match the value returned by the
   // SubscribePermissionStatusChange call.
   virtual void UnsubscribePermissionStatusChange(int subscription_id) = 0;
 };
 
 }  // namespace content
 
 #endif // CONTENT_PUBLIC_BROWSER_PERMISSION_MANAGER_H_