renderer: implement multiple permission requesting

content/browser/permissions/permission_pending_request.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_PERMISSIONS_PERMISSION_PENDING_REQUEST_H_
+#define CONTENT_BROWSER_PERMISSIONS_PERMISSION_PENDING_REQUEST_H_
+
+#include "base/callback_forward.h"
+#include "base/macros.h"
+#include "content/common/permission_service.mojom.h"

[mlamouri (slow - plz ping), 2015/09/02 11:36:41]

Do you really need that?

[Lalit Maganti, 2015/09/02 14:24:50]

No. But I do need the Mojo callback file. Yay for getting rid of transitive
dependencies.

+#include "third_party/mojo/src/mojo/public/cpp/bindings/binding.h"

[mlamouri (slow - plz ping), 2015/09/02 11:36:41]

and that?

[Lalit Maganti, 2015/09/02 14:24:50]

And no.

+#include "url/gurl.h"

[mlamouri (slow - plz ping), 2015/09/02 11:36:41]

and that?

[Lalit Maganti, 2015/09/02 14:24:50]

And no :)

+
+namespace content {
+
+enum class PermissionType;
+
+class PermissionPendingRequest {

[mlamouri (slow - plz ping), 2015/09/02 11:36:41]

Why isn't that part of the mojo service implementation? It seems that it could
have stayed there. Not that I'm against having it in its own file but it seems
to be a fairly simple class.

[Lalit Maganti, 2015/09/02 14:24:50]

TBH it could probably be moved back to permisison_manager. At one point it was
much more complex than it is now.

I don't mind either way - I can move it back if you prefer.

+ public:
+  using PermissionRequestCallback =
+      mojo::Callback<void(mojo::Array<PermissionStatus>)>;
+
+  PermissionPendingRequest(PermissionRequestCallback callback,
+                           int request_count);
+  ~PermissionPendingRequest();
+
+  PermissionRequestCallback& callback() { return callback_; }
+
+ private:
+  PermissionRequestCallback callback_;
+  int request_count_;
+
+ DISALLOW_COPY_AND_ASSIGN(PermissionPendingRequest);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_PERMISSIONS_PERMISSION_PENDING_REQUEST_H_