renderer: implement multiple permission requesting

chrome/browser/permissions/permission_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_MANAGER_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_MANAGER_H_
 
 #include "base/callback_forward.h"
+#include "base/containers/scoped_ptr_hash_map.h"
 #include "base/id_map.h"
 #include "base/macros.h"
+#include "base/memory/weak_ptr.h"
 #include "components/content_settings/core/browser/content_settings_observer.h"
+#include "components/content_settings/core/common/content_settings.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "content/public/browser/permission_manager.h"
 
 
+class PermissionRequestID;
 class Profile;
 
 namespace content {
 enum class PermissionType;
 };  // namespace content
 
 class PermissionManager : public KeyedService,
                           public content::PermissionManager,
                           public content_settings::Observer {
  public:
   explicit PermissionManager(Profile* profile);
   ~PermissionManager() override;
 
   // content::PermissionManager implementation.
   void RequestPermission(
       content::PermissionType permission,
       content::RenderFrameHost* render_frame_host,
       int request_id,
       const GURL& requesting_origin,
       bool user_gesture,
-      const base::Callback<void(content::PermissionStatus)>& callback) override;
-  void CancelPermissionRequest(content::PermissionType permission,
-                               content::RenderFrameHost* render_frame_host,
-                               int request_id,
-                               const GURL& requesting_origin) override;
+      const RequestCallback& callback) override;
+  void RequestPermission(

[mlamouri (slow - plz ping), 2015/09/02 11:36:41]

RequestPermissions ?

[Lalit Maganti, 2015/09/02 14:24:50]

Done.

+      const std::vector<content::PermissionType>& permissions,
+      content::RenderFrameHost* render_frame_host,
+      int request_id,
+      const GURL& requesting_origin,
+      bool user_gesture,
+      const BatchRequestCallback& callback) override;

[mlamouri (slow - plz ping), 2015/09/02 11:36:41]

use the real callback type?

[Lalit Maganti, 2015/09/02 14:24:50]

Makes the line too long and breaking it up looks ugly in most ways.

Anyway, I've tried to do so.

+  void CancelPermissionRequest(content::RenderFrameHost* render_frame_host,
+                                int request_id) override;
   void ResetPermission(content::PermissionType permission,
                        const GURL& requesting_origin,
                        const GURL& embedding_origin) override;
   content::PermissionStatus GetPermissionStatus(
       content::PermissionType permission,
       const GURL& requesting_origin,
       const GURL& embedding_origin) override;
   void RegisterPermissionUsage(content::PermissionType permission,
                                const GURL& requesting_origin,
                                const GURL& embedding_origin) override;
   int SubscribePermissionStatusChange(
       content::PermissionType permission,
       const GURL& requesting_origin,
       const GURL& embedding_origin,
       const base::Callback<void(content::PermissionStatus)>& callback) override;
   void UnsubscribePermissionStatusChange(int subscription_id) override;
 
  private:
   struct Subscription;
   using SubscriptionsMap = IDMap<Subscription, IDMapOwnPointer>;
 
+  struct PendingResponses;
+  struct PendingResponse;
+  using PendingResponseMap
+      = base::ScopedPtrHashMap<int, scoped_ptr<PendingResponses>>;

[mlamouri (slow - plz ping), 2015/09/02 11:36:41]

nit: = on previous line.

[Lalit Maganti, 2015/09/02 14:24:50]

Done.

+
+  void RequestPermissionInternal(
+      const std::vector<content::PermissionType>& permissions,
+      content::RenderFrameHost* render_frame_host,
+      int request_id,
+      const GURL& requesting_origin,
+      bool user_gesture,
+      const BatchRequestCallback& callback);
+
+  void OnRequestResponse(
+      const BatchRequestCallback& callback,
+      const PermissionRequestID request,
+      PendingResponses* pending_responses,
+      int index,
+      ContentSetting content_setting);
+
   // content_settings::Observer implementation.
   void OnContentSettingChanged(const ContentSettingsPattern& primary_pattern,
                                const ContentSettingsPattern& secondary_pattern,
                                ContentSettingsType content_type,
                                std::string resource_identifier) override;
 
   Profile* profile_;
   SubscriptionsMap subscriptions_;
+  PendingResponseMap pending_responses_;
+
+  // Need to keep this as the last member so it is destroyed before any other
+  // fields.
+  base::WeakPtrFactory<PermissionManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PermissionManager);
 };
 
 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_MANAGER_H_