Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: media/filters/ffmpeg_demuxer.h

Issue 1260193005: Fix incorrect opus seek preroll and flaky pre-skip removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mojo renderer. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_audio_decoder.cc ('k') | media/filters/ffmpeg_demuxer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_demuxer.h
diff --git a/media/filters/ffmpeg_demuxer.h b/media/filters/ffmpeg_demuxer.h
index 98ee3b2844aa4ae9c12b0719a18ee24a99be8658..bc7c3bd525320e2bd33c04923b9e0aa83264934a 100644
--- a/media/filters/ffmpeg_demuxer.h
+++ b/media/filters/ffmpeg_demuxer.h
@@ -77,12 +77,17 @@ class FFmpegDemuxerStream : public DemuxerStream {
base::TimeDelta duration() const { return duration_; }
- // Enables fixes for ogg files with negative timestamps. For AUDIO streams,
- // all packets with negative timestamps will be marked for post-decode
- // discard. For all other stream types, if FFmpegDemuxer::start_time() is
- // negative, it will not be used to shift timestamps during EnqueuePacket().
- void enable_negative_timestamp_fixups_for_ogg() {
- fixup_negative_ogg_timestamps_ = true;
+ // Enables fixes for files with negative timestamps. Normally all timestamps
+ // are rebased against FFmpegDemuxer::start_time() whenever that value is
+ // negative. When this fix is enabled, only AUDIO stream packets will be
+ // rebased to time zero, all other stream types will use the muxed timestamp.
+ //
+ // Further, when no codec delay is present, all AUDIO packets which originally
+ // had negative timestamps will be marked for post-decode discard. When codec
+ // delay is present, it is assumed the decoder will handle discard and does
+ // not need the AUDIO packets to be marked for discard; just rebased to zero.
+ void enable_negative_timestamp_fixups() {
+ fixup_negative_timestamps_ = true;
}
// DemuxerStream implementation.
@@ -155,7 +160,7 @@ class FFmpegDemuxerStream : public DemuxerStream {
#endif
std::string encryption_key_id_;
- bool fixup_negative_ogg_timestamps_;
+ bool fixup_negative_timestamps_;
DISALLOW_COPY_AND_ASSIGN(FFmpegDemuxerStream);
};
« no previous file with comments | « media/filters/ffmpeg_audio_decoder.cc ('k') | media/filters/ffmpeg_demuxer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698