Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: media/base/audio_discard_helper.cc

Issue 1260193005: Fix incorrect opus seek preroll and flaky pre-skip removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mojo renderer. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/clockless_audio_sink.cc ('k') | media/filters/ffmpeg_audio_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_discard_helper.cc
diff --git a/media/base/audio_discard_helper.cc b/media/base/audio_discard_helper.cc
index f7c645cc20e6b2098e2b90764eb4ff75ee5424e7..12c8e347d2c203f3f294ff07c9a1a5df905d7e26 100644
--- a/media/base/audio_discard_helper.cc
+++ b/media/base/audio_discard_helper.cc
@@ -104,11 +104,8 @@ bool AudioDiscardHelper::ProcessBuffers(
// If everything would be discarded, indicate a new buffer is required.
if (frames_to_discard == decoded_frames) {
- // For simplicity disallow cases where a buffer with discard padding is
- // present. Doing so allows us to avoid complexity around tracking
- // discards across buffers.
- DCHECK(current_discard_padding.first == base::TimeDelta());
- DCHECK(current_discard_padding.second == base::TimeDelta());
+ // For simplicity, we just drop any discard padding if |discard_frames_|
+ // consumes the entire buffer.
return false;
}
« no previous file with comments | « media/audio/clockless_audio_sink.cc ('k') | media/filters/ffmpeg_audio_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698