Fix incorrect opus seek preroll and flaky pre-skip removal.

media/test/pipeline_integration_test_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_TEST_PIPELINE_INTEGRATION_TEST_BASE_H_
 #define MEDIA_TEST_PIPELINE_INTEGRATION_TEST_BASE_H_
 
 #include "base/md5.h"
 #include "base/message_loop/message_loop.h"
 #include "media/audio/clockless_audio_sink.h"
@@ skipping 54 matching lines @@
 
   // Starts the pipeline (optionally with a CdmContext), returning the final
   // status code after it has started. |filename| points at a test file located
   // under media/test/data/.
   PipelineStatus Start(const std::string& filename);
   PipelineStatus Start(const std::string& filename, CdmContext* cdm_context);
 
   // Starts the pipeline in a particular mode for advanced testing and
   // benchmarking purposes (e.g., underflow is disabled to ensure consistent
   // hashes).
-  enum kTestType { kHashed, kClockless };
-  PipelineStatus Start(const std::string& filename, kTestType test_type);
+  enum TestType { kHashed = 1, kClockless = 2};

[wolenetz, 2015/07/29 21:57:27]

nit: include "Flags" in the name to indicate that these are not exclusive of
each other, but instead part of a mask?

[DaleCurtis, 2015/07/30 01:28:14]

Done.

+  PipelineStatus Start(const std::string& filename, uint8_t test_type);
 
   void Play();
   void Pause();
   bool Seek(base::TimeDelta seek_time);
   void Stop();
   bool WaitUntilCurrentTimeIsAfter(const base::TimeDelta& wait_time);
 
   // Returns the MD5 hash of all video frames seen.  Should only be called once
   // after playback completes.  First time hashes should be generated with
   // --video-threads=1 to ensure correctness.  Pipeline must have been started
@@ skipping 55 matching lines @@
   MOCK_METHOD1(DecryptorAttached, void(bool));
   MOCK_METHOD2(OnAddTextTrack,
                void(const TextTrackConfig& config,
                     const AddTextTrackDoneCB& done_cb));
   MOCK_METHOD0(OnWaitingForDecryptionKey, void(void));
 };
 
 }  // namespace media
 
 #endif  // MEDIA_TEST_PIPELINE_INTEGRATION_TEST_BASE_H_