Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1260183008: Order jump tables for deterministic or randomized emission. (Closed)

Created:
5 years, 4 months ago by ascull
Modified:
5 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix sort comparison. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -17 lines) Patch
M src/IceGlobalContext.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 1 chunk +24 lines, -3 lines 0 comments Download
M src/IceSwitchLowering.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/IceTargetLoweringX8664.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ascull
I used the constant pool randomization flag for jump tables too.
5 years, 4 months ago (2015-08-04 19:28:45 UTC) #2
Jim Stichnoth
https://codereview.chromium.org/1260183008/diff/1/src/IceGlobalContext.cpp File src/IceGlobalContext.cpp (right): https://codereview.chromium.org/1260183008/diff/1/src/IceGlobalContext.cpp#newcode894 src/IceGlobalContext.cpp:894: return A.getFunctionName() < B.getFunctionName() || A.getId() < B.getId(); Is ...
5 years, 4 months ago (2015-08-04 20:22:52 UTC) #3
ascull
https://codereview.chromium.org/1260183008/diff/1/src/IceGlobalContext.cpp File src/IceGlobalContext.cpp (right): https://codereview.chromium.org/1260183008/diff/1/src/IceGlobalContext.cpp#newcode894 src/IceGlobalContext.cpp:894: return A.getFunctionName() < B.getFunctionName() || A.getId() < B.getId(); On ...
5 years, 4 months ago (2015-08-04 20:36:38 UTC) #4
Jim Stichnoth
lgtm
5 years, 4 months ago (2015-08-04 22:25:56 UTC) #5
ascull
5 years, 4 months ago (2015-08-05 00:03:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1eda90a112993eb171b8f60e5470b554e59542af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698