Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1260183003: Add basic unittests for devtools http_server. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add a test for gzip content encoding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A mojo/devtools/common/devtoolslib/http_server_unittest.py View 1 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-08-04 09:58:39 UTC) #1
qsr
lgtm
5 years, 4 months ago (2015-08-04 13:49:00 UTC) #2
ppi
5 years, 4 months ago (2015-08-04 13:53:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5aee8c2d8d5c705b20a7f27b86817cb10c1b799e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698