Subzero. Removes references to %ah.

src/IceRegistersX8632.h

 //===- subzero/src/IceRegistersX8632.h - Register information ---*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 70 matching lines @@
     assert(Reg_GPR_First <= RegNum && RegNum <= Reg_GPR_Last);
     return GPRRegister(RegNum - Reg_GPR_First);
   }
 
   static inline XmmRegister getEncodedXmm(int32_t RegNum) {
     assert(Reg_XMM_First <= RegNum && RegNum <= Reg_XMM_Last);
     return XmmRegister(RegNum - Reg_XMM_First);
   }
 
   static inline ByteRegister getEncodedByteReg(int32_t RegNum) {
-    assert(RegNum == Reg_ah || (Reg_GPR_First <= RegNum && RegNum <= Reg_ebx));
-    if (RegNum == Reg_ah)
-      return Encoded_Reg_ah;
+    assert(Reg_GPR_First <= RegNum && RegNum <= Reg_ebx);

[Jim Stichnoth, 2015/07/28 15:58:23]

I must have missed this before, but now that it's in my sights...

For asserts like
  assert(A && B);
I prefer breaking it into
  assert(A);
  assert(B);
which gives more precise information when the assertion fails.

[John, 2015/07/28 18:21:16]

Nothing that a simple

:%s/assert(\([^&]\+\) && \([^)]\+\))/assert(\1);assert(\2)

won't solve. :)

     return ByteRegister(RegNum - Reg_GPR_First);
   }
 
   static inline GPRRegister getEncodedByteRegOrGPR(Type Ty, int32_t RegNum) {
     if (isByteSizedType(Ty))
       return GPRRegister(getEncodedByteReg(RegNum));
     else
       return getEncodedGPR(RegNum);
   }
 
   static inline X87STRegister getEncodedSTReg(int32_t RegNum) {
     assert(Encoded_X87ST_First <= RegNum && RegNum <= Encoded_X87ST_Last);
     return X87STRegister(RegNum);
   }
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEREGISTERSX8632_H