Adds an experiment that enabled SuggestionsService suggestions (MostLikely) on LocalNTP

chrome/renderer/searchbox/searchbox_extension.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox_extension.h"
 
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/json/string_escape.h"
 #include "base/metrics/field_trial.h"
@@ skipping 134 matching lines @@
 
   base::string16 title = mv_item.title;
   if (title.empty())
     title = base::UTF8ToUTF16(mv_item.url.spec());
 
   v8::Local<v8::Object> obj = v8::Object::New(isolate);
   obj->Set(v8::String::NewFromUtf8(isolate, "renderViewId"),
            v8::Int32::New(isolate, render_view_id));
   obj->Set(v8::String::NewFromUtf8(isolate, "rid"),
            v8::Int32::New(isolate, restricted_id));
-  obj->Set(v8::String::NewFromUtf8(isolate, "thumbnailUrl"),
-           GenerateThumbnailURL(isolate, render_view_id, restricted_id));
+
+  // If the suggestion already has a suggested thumbnail, we create an thumbnail
+  // array with both the local thumbnail and the proposed one.
+  // Otherwise, we just create an array with the generated one.
+  if (!mv_item.thumbnail.spec().empty()) {
+    v8::Local<v8::Array> thumbs = v8::Array::New(isolate, 2);
+    thumbs->Set(0, UTF8ToV8String(isolate, base::StringPrintf(

[kmadhusu, 2015/07/31 21:05:45]

nit: Create a helper function to generate this thumbnail url. It will be much
easier to read this code.

[fserb, 2015/08/05 14:56:26]

Done.

+                                               "chrome-search://thumb2/%s",
+                                               mv_item.url.spec().c_str())));
+    thumbs->Set(1, UTF8ToV8String(isolate, mv_item.thumbnail.spec()));
+    obj->Set(v8::String::NewFromUtf8(isolate, "thumbnailUrls"), thumbs);
+  } else {
+    v8::Local<v8::Array> thumbs = v8::Array::New(isolate, 1);
+    thumbs->Set(0,
+                GenerateThumbnailURL(isolate, render_view_id, restricted_id));
+    obj->Set(v8::String::NewFromUtf8(isolate, "thumbnailUrls"), thumbs);
+  }
+
+  // If the suggestion already has a favicon, we populate the element with it.
+  if (!mv_item.favicon.spec().empty()) {
+    obj->Set(v8::String::NewFromUtf8(isolate, "faviconUrl"),
+             UTF8ToV8String(isolate, mv_item.favicon.spec()));
+  }
+
   if (IsIconNTPEnabled()) {
     // Update website http://www.chromium.org/embeddedsearch when we make this
     // permanent.
     // Large icon size is 48px * window.devicePixelRatio. This is easier to set
     // from JS, where IsIconNTPEnabled() is not available. So we add stubs
     // here, and let JS fill in details.
     obj->Set(v8::String::NewFromUtf8(isolate, "largeIconUrl"),
              v8::String::NewFromUtf8(isolate, "chrome-search://large-icon/"));
     obj->Set(v8::String::NewFromUtf8(isolate, "fallbackIconUrl"),
         v8::String::NewFromUtf8(isolate, "chrome-search://fallback-icon/"));
@@ skipping 1106 matching lines @@
   if (!render_view) return;
 
   bool display_instant_results =
       SearchBox::Get(render_view)->display_instant_results();
   DVLOG(1) << render_view << " GetDisplayInstantResults" <<
       display_instant_results;
   args.GetReturnValue().Set(display_instant_results);
 }
 
 }  // namespace extensions_v8