[Telemetry] Update cloud_storage to use telemetry/third_party/gsutilz/gsutil

[Telemetry] Update cloud_storage to use telemetry/third_party/gsutilz/gsutil

BUG=508721
try job run on smoothness.top_25_smooth: https://codereview.chromium.org/1267063002

Committed: https://crrev.com/8235a365e0845abcf25704999cbcdaa7722051dd
Cr-Commit-Position: refs/heads/master@{#341560}

[nednguyen, 2015-07-29 18:01:18]

nednguyen@google.com changed reviewers:
+ aiolos@chromium.org, pdr@chromium.org

[nednguyen, 2015-07-29 18:01:19]

https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_ba...
File tools/telemetry/catapult_base/cloud_storage.py (left):

https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_ba...
tools/telemetry/catapult_base/cloud_storage.py:118: def
SupportsProdaccess(gsutil_path):
I delete this because this code doesn't make any sense to me. Seems it check the
source code of gsutil script to find the word 'prodaccess'? :-/

[aiolos (Not reviewing), 2015-07-29 23:22:28]

https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_ba...
File tools/telemetry/catapult_base/cloud_storage.py (left):

https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_ba...
tools/telemetry/catapult_base/cloud_storage.py:118: def
SupportsProdaccess(gsutil_path):
On 2015/07/29 18:01:19, nednguyen wrote:
> I delete this because this code doesn't make any sense to me. Seems it check
the
> source code of gsutil script to find the word 'prodaccess'? :-/

I *think* this is fine to remove at this point, but you'll need to update the
unittests at least. (ie, I don't think gsutil authenticates through prodaccess
anymore.) (I think find_dependencies_unittest.py is the only one that covers
this code path.)

[aiolos (Not reviewing), 2015-07-29 23:26:29]

https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_ba...
File tools/telemetry/catapult_base/cloud_storage.py (left):

https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_ba...
tools/telemetry/catapult_base/cloud_storage.py:118: def
SupportsProdaccess(gsutil_path):
On 2015/07/29 23:22:27, aiolos wrote:
> On 2015/07/29 18:01:19, nednguyen wrote:
> > I delete this because this code doesn't make any sense to me. Seems it check
> the
> > source code of gsutil script to find the word 'prodaccess'? :-/
> 
> I *think* this is fine to remove at this point, but you'll need to update the
> unittests at least. (ie, I don't think gsutil authenticates through prodaccess
> anymore.) (I think find_dependencies_unittest.py is the only one that covers
> this code path.)

It might make more sense to do this in a separate cl.

[nednguyen, 2015-08-01 04:16:17]

https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_ba...
File tools/telemetry/catapult_base/cloud_storage.py (left):

https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_ba...
tools/telemetry/catapult_base/cloud_storage.py:118: def
SupportsProdaccess(gsutil_path):
On 2015/07/29 23:26:29, aiolos (slow review) wrote:
> On 2015/07/29 23:22:27, aiolos wrote:
> > On 2015/07/29 18:01:19, nednguyen wrote:
> > > I delete this because this code doesn't make any sense to me. Seems it
check
> > the
> > > source code of gsutil script to find the word 'prodaccess'? :-/
> > 
> > I *think* this is fine to remove at this point, but you'll need to update
the
> > unittests at least. (ie, I don't think gsutil authenticates through
prodaccess
> > anymore.) (I think find_dependencies_unittest.py is the only one that covers
> > this code path.)
> 
> It might make more sense to do this in a separate cl.

Done.

[nednguyen, 2015-08-01 04:48:11]

Patchset #4 (id:60001) has been deleted

[pdr., 2015-08-03 17:21:20]

LGTM, thanks!

[nednguyen, 2015-08-03 17:21:38]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-08-03 17:23:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083007/40001

[commit-bot: I haz the power, 2015-08-03 18:29:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-03 18:30:56]

Patchset 3 (id:??) landed as
https://crrev.com/8235a365e0845abcf25704999cbcdaa7722051dd
Cr-Commit-Position: refs/heads/master@{#341560}