Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 1260083007: [Telemetry] Update cloud_storage to use telemetry/third_party/gsutilz/gsutil (Closed)

Created:
5 years, 4 months ago by nednguyen
Modified:
5 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Update cloud_storage to use telemetry/third_party/gsutilz/gsutil BUG=508721 try job run on smoothness.top_25_smooth: https://codereview.chromium.org/1267063002 Committed: https://crrev.com/8235a365e0845abcf25704999cbcdaa7722051dd Cr-Commit-Position: refs/heads/master@{#341560}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase #

Patch Set 3 : Fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -57 lines) Patch
M tools/telemetry/catapult_base/cloud_storage.py View 1 6 chunks +15 lines, -47 lines 0 comments Download
M tools/telemetry/catapult_base/cloud_storage_unittest.py View 1 2 4 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
nednguyen
https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_base/cloud_storage.py File tools/telemetry/catapult_base/cloud_storage.py (left): https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_base/cloud_storage.py#oldcode118 tools/telemetry/catapult_base/cloud_storage.py:118: def SupportsProdaccess(gsutil_path): I delete this because this code doesn't ...
5 years, 4 months ago (2015-07-29 18:01:19 UTC) #2
aiolos (Not reviewing)
https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_base/cloud_storage.py File tools/telemetry/catapult_base/cloud_storage.py (left): https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_base/cloud_storage.py#oldcode118 tools/telemetry/catapult_base/cloud_storage.py:118: def SupportsProdaccess(gsutil_path): On 2015/07/29 18:01:19, nednguyen wrote: > I ...
5 years, 4 months ago (2015-07-29 23:22:28 UTC) #3
aiolos (Not reviewing)
https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_base/cloud_storage.py File tools/telemetry/catapult_base/cloud_storage.py (left): https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_base/cloud_storage.py#oldcode118 tools/telemetry/catapult_base/cloud_storage.py:118: def SupportsProdaccess(gsutil_path): On 2015/07/29 23:22:27, aiolos wrote: > On ...
5 years, 4 months ago (2015-07-29 23:26:29 UTC) #4
nednguyen
https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_base/cloud_storage.py File tools/telemetry/catapult_base/cloud_storage.py (left): https://codereview.chromium.org/1260083007/diff/1/tools/telemetry/catapult_base/cloud_storage.py#oldcode118 tools/telemetry/catapult_base/cloud_storage.py:118: def SupportsProdaccess(gsutil_path): On 2015/07/29 23:26:29, aiolos (slow review) wrote: ...
5 years, 4 months ago (2015-08-01 04:16:17 UTC) #5
pdr.
LGTM, thanks!
5 years, 4 months ago (2015-08-03 17:21:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260083007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260083007/40001
5 years, 4 months ago (2015-08-03 17:23:08 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-03 18:29:39 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 18:30:56 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8235a365e0845abcf25704999cbcdaa7722051dd
Cr-Commit-Position: refs/heads/master@{#341560}

Powered by Google App Engine
This is Rietveld 408576698