Add needed functions to glibc-compat for pkg

Add needed functions to glibc-compat for pkg

Add minimal tests to newly added functions. Some of them are not
available as fchdir is not implemented in sel_ldr.

Committed: https://chromium.googlesource.com/external/naclports/+/defa2be0fe3bcb5987b64ddbec35cddc428ba9d2

[zhitingzhu, 2015-07-27 23:48:53]

zhitingzhu@google.com changed reviewers:
+ sbc@google.com

[Sam Clegg, 2015-07-28 00:14:13]

sbc@chromium.org changed reviewers:
+ sbc@chromium.org

[Sam Clegg, 2015-07-28 00:14:14]

lgtm, with comments

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/include/...
File ports/glibc-compat/include/sys/un.h (right):

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/include/...
ports/glibc-compat/include/sys/un.h:23: /* end of olonho */
Maybe remove these olonho comments too.  He used to work on the project but
doesn't anymore.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/file.c
File ports/glibc-compat/src/file.c (right):

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/file...
ports/glibc-compat/src/file.c:1: /*
Can you call this file somemore meaningfull?  Perhaps "openat.c"?

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/file...
ports/glibc-compat/src/file.c:16: char *xgetcwd(void) {
static?

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test.cc
File ports/glibc-compat/src/test.cc (right):

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test...
ports/glibc-compat/src/test.cc:107: read_iov[0].iov_len = 28;
sizeof(first)?

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test...
ports/glibc-compat/src/test.cc:114: char str1[] =
"abcdefghijklmnopqrstuvwxyz\n";
Why not 'const char*'?

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test...
ports/glibc-compat/src/test.cc:118: write_iov[0].iov_len = 28;
sizeof?

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test...
ports/glibc-compat/src/test.cc:132: ASSERT_STREQ("abcdefghijklmnopqrstuvwxyz\n",
Use str1 here?

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test...
ports/glibc-compat/src/test.cc:184: // Can't tested err as it will let the test
program fail.
Can you elaborate or re-phrase this comment?  Its not clear what you mean.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/time...
File ports/glibc-compat/src/timegm.c (right):

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/time...
ports/glibc-compat/src/timegm.c:1: /* Copyright 2015 The Native Client Authors.
All rights reserved.
nit: put /* and */ on lines be themselves to match other files in this
directory.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/writ...
File ports/glibc-compat/src/writev.c (right):

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/writ...
ports/glibc-compat/src/writev.c:32: ssize_t readv(int fd, const struct iovec
*iov, int iovcnt) {
It looks like it might be possible to remove some of the ports/xtrans/nacl.patch
and ports/libxcb/nacl.patch now that we have these here?

Also, you can remove the writev macro from glibc-compat/src/herror.c (I believe
that was added by us)

[zhitingzhu, 2015-07-28 02:05:41]

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/include/...
File ports/glibc-compat/include/sys/un.h (right):

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/include/...
ports/glibc-compat/include/sys/un.h:23: /* end of olonho */
On 2015/07/28 00:14:13, Sam Clegg wrote:
> Maybe remove these olonho comments too.  He used to work on the project but
> doesn't anymore.

Done.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/file.c
File ports/glibc-compat/src/file.c (right):

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/file...
ports/glibc-compat/src/file.c:1: /*
On 2015/07/28 00:14:13, Sam Clegg wrote:
> Can you call this file somemore meaningfull?  Perhaps "openat.c"?  

Done.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/file...
ports/glibc-compat/src/file.c:16: char *xgetcwd(void) {
On 2015/07/28 00:14:13, Sam Clegg wrote:
> static?

Done.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test.cc
File ports/glibc-compat/src/test.cc (right):

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test...
ports/glibc-compat/src/test.cc:107: read_iov[0].iov_len = 28;
On 2015/07/28 00:14:13, Sam Clegg wrote:
> sizeof(first)?

Done.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test...
ports/glibc-compat/src/test.cc:114: char str1[] =
"abcdefghijklmnopqrstuvwxyz\n";
On 2015/07/28 00:14:13, Sam Clegg wrote:
> Why not 'const char*'?

Done.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test...
ports/glibc-compat/src/test.cc:118: write_iov[0].iov_len = 28;
On 2015/07/28 00:14:13, Sam Clegg wrote:
> sizeof?

Done.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test...
ports/glibc-compat/src/test.cc:132: ASSERT_STREQ("abcdefghijklmnopqrstuvwxyz\n",
On 2015/07/28 00:14:13, Sam Clegg wrote:
> Use str1 here?

Done.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/test...
ports/glibc-compat/src/test.cc:184: // Can't tested err as it will let the test
program fail.
On 2015/07/28 00:14:13, Sam Clegg wrote:
> Can you elaborate or re-phrase this comment?  Its not clear what you mean.

Done.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/time...
File ports/glibc-compat/src/timegm.c (right):

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/time...
ports/glibc-compat/src/timegm.c:1: /* Copyright 2015 The Native Client Authors.
All rights reserved.
On 2015/07/28 00:14:13, Sam Clegg wrote:
> nit: put /* and */ on lines be themselves to match other files in this
> directory.

Done.

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/writ...
File ports/glibc-compat/src/writev.c (right):

https://codereview.chromium.org/1260083004/diff/1/ports/glibc-compat/src/writ...
ports/glibc-compat/src/writev.c:32: ssize_t readv(int fd, const struct iovec
*iov, int iovcnt) {
On 2015/07/28 00:14:13, Sam Clegg wrote:
> It looks like it might be possible to remove some of the
ports/xtrans/nacl.patch
> and ports/libxcb/nacl.patch now that we have these here?
> 
> Also, you can remove the writev macro from glibc-compat/src/herror.c (I
believe
> that was added by us)

Done.

[Sam Clegg, 2015-07-28 16:25:58]

lgtm

https://codereview.chromium.org/1260083004/diff/20001/ports/glibc-compat/src/...
File ports/glibc-compat/src/timegm.c (right):

https://codereview.chromium.org/1260083004/diff/20001/ports/glibc-compat/src/...
ports/glibc-compat/src/timegm.c:1: /* Copyright 2015 The Native Client Authors.
All rights reserved.
nit: newline here

[Sam Clegg, 2015-07-28 16:26:09]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-28 16:26:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083004/20001

[commit-bot: I haz the power, 2015-07-28 16:27:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-28 16:27:08]

Dry run: Try jobs failed on following builders:
  naclports-linux-clang-1 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-1/b...)
  naclports-linux-clang-3 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-3/b...)
  naclports-linux-glibc-1 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-1/b...)
  naclports-linux-newlib-0 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-0/...)
  naclports-linux-newlib-1 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-1/...)
  naclports-linux-newlib-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-4/...)
  naclports-linux-pnacl-2 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-2/b...)
  naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...)

[Sam Clegg, 2015-07-28 16:29:19]

On 2015/07/28 16:27:08, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   naclports-linux-clang-1 on tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-1/b...)
>   naclports-linux-clang-3 on tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-3/b...)
>   naclports-linux-glibc-1 on tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-1/b...)
>   naclports-linux-newlib-0 on tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-0/...)
>   naclports-linux-newlib-1 on tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-1/...)
>   naclports-linux-newlib-4 on tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-4/...)
>   naclports-linux-pnacl-2 on tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-2/b...)
>   naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...)

looks like you might need to merge/rebase this change.

[zhitingzhu, 2015-07-28 16:39:23]

https://codereview.chromium.org/1260083004/diff/20001/ports/glibc-compat/src/...
File ports/glibc-compat/src/timegm.c (right):

https://codereview.chromium.org/1260083004/diff/20001/ports/glibc-compat/src/...
ports/glibc-compat/src/timegm.c:1: /* Copyright 2015 The Native Client Authors.
All rights reserved.
On 2015/07/28 16:25:57, Sam Clegg wrote:
> nit: newline here

Done.

[Sam Clegg, 2015-07-28 16:40:46]

On 2015/07/28 16:39:23, zhitingzhu wrote:
>
https://codereview.chromium.org/1260083004/diff/20001/ports/glibc-compat/src/...
> File ports/glibc-compat/src/timegm.c (right):
> 
>
https://codereview.chromium.org/1260083004/diff/20001/ports/glibc-compat/src/...
> ports/glibc-compat/src/timegm.c:1: /* Copyright 2015 The Native Client
Authors.
> All rights reserved.
> On 2015/07/28 16:25:57, Sam Clegg wrote:
> > nit: newline here
> 
> Done.

Great.  Please hit the CQ button and we can see if we can get this landed.

[zhitingzhu, 2015-07-28 16:41:19]

The CQ bit was checked by zhitingzhu@google.com

[zhitingzhu, 2015-07-28 16:41:20]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/1260083004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-07-28 16:41:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083004/40001

[commit-bot: I haz the power, 2015-07-28 16:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-28 16:43:42]

Try jobs failed on following builders:
  naclports-presubmit on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-presubmit/build...)

[Sam Clegg, 2015-07-28 17:03:55]

On 2015/07/28 17:01:04, zhitingzhu wrote:

You can add NOPRESUBMIT=true to the CL description to get around the presubmit
checks if you like.  Those files clearly don't require our copyright.

[zhitingzhu, 2015-07-28 17:05:04]

The CQ bit was checked by zhitingzhu@google.com

[zhitingzhu, 2015-07-28 17:05:04]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/1260083004/#ps60001
(title: "add bypass in presubmit")

[commit-bot: I haz the power, 2015-07-28 17:05:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083004/60001

[commit-bot: I haz the power, 2015-07-28 18:58:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-28 18:58:37]

Try jobs failed on following builders:
  naclports-linux-clang-2 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-2/b...)

[zhitingzhu, 2015-07-28 21:22:40]

The CQ bit was checked by zhitingzhu@google.com

[zhitingzhu, 2015-07-28 21:22:41]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/1260083004/#ps80001
(title: "fix python build failure")

[commit-bot: I haz the power, 2015-07-28 21:22:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083004/80001

[commit-bot: I haz the power, 2015-07-29 02:09:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 02:09:25]

Try jobs failed on following builders:
  naclports-linux-newlib-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-4/...)

[Sam Clegg, 2015-07-29 04:49:47]

On 2015/07/29 02:09:25, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   naclports-linux-newlib-4 on tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-4/...)

Almost there.  Looks like cairo needs to link against glibc-compat.

[zhitingzhu, 2015-07-29 18:34:29]

The CQ bit was checked by zhitingzhu@google.com

[zhitingzhu, 2015-07-29 18:34:29]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/1260083004/#ps100001
(title: "link glibc-compat lib in libx11 and libxcb")

[commit-bot: I haz the power, 2015-07-29 18:34:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083004/100001

[commit-bot: I haz the power, 2015-07-29 23:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 23:17:35]

Try jobs failed on following builders:
  naclports-linux-newlib-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-4/...)

[zhitingzhu, 2015-07-29 23:51:07]

The CQ bit was checked by zhitingzhu@google.com

[zhitingzhu, 2015-07-29 23:51:07]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/1260083004/#ps120001
(title: "another attempt to fix cairo")

[commit-bot: I haz the power, 2015-07-29 23:51:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083004/120001

[Sam Clegg, 2015-07-29 23:58:49]

https://codereview.chromium.org/1260083004/diff/120001/ports/libxcb/nacl.patch
File ports/libxcb/nacl.patch (right):

https://codereview.chromium.org/1260083004/diff/120001/ports/libxcb/nacl.patc...
ports/libxcb/nacl.patch:3: +++ b/configure
Sorry, can you remove this configure patch that is auto-generated.   updatepatch
should really skip it but I guess its not smart enough yet.

If this lands that fine, we can remove it later.

[commit-bot: I haz the power, 2015-07-30 02:45:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-30 02:45:23]

Try jobs failed on following builders:
  naclports-linux-clang-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-4/b...)

[zhitingzhu, 2015-07-31 01:06:41]

https://codereview.chromium.org/1260083004/diff/120001/ports/libxcb/nacl.patch
File ports/libxcb/nacl.patch (right):

https://codereview.chromium.org/1260083004/diff/120001/ports/libxcb/nacl.patc...
ports/libxcb/nacl.patch:3: +++ b/configure
On 2015/07/29 23:58:49, Sam Clegg wrote:
> Sorry, can you remove this configure patch that is auto-generated.  
updatepatch
> should really skip it but I guess its not smart enough yet.
> 
> If this lands that fine, we can remove it later.

Done.

[zhitingzhu, 2015-07-31 01:06:56]

The CQ bit was checked by zhitingzhu@google.com

[zhitingzhu, 2015-07-31 01:06:57]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/1260083004/#ps140001
(title: "another attempt to get pass cairo")

[commit-bot: I haz the power, 2015-07-31 01:07:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083004/140001

[commit-bot: I haz the power, 2015-07-31 09:12:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-31 09:12:14]

Try jobs failed on following builders:
  naclports-linux-glibc-2 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-2/b...)

[zhitingzhu, 2015-07-31 22:06:45]

The CQ bit was checked by zhitingzhu@google.com

[zhitingzhu, 2015-07-31 22:06:46]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/1260083004/#ps160001
(title: "try to fix gtk+")

[commit-bot: I haz the power, 2015-07-31 22:06:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083004/160001

[Sam Clegg, 2015-07-31 22:07:00]

https://codereview.chromium.org/1260083004/diff/160001/ports/cairo/build.sh
File ports/cairo/build.sh (right):

https://codereview.chromium.org/1260083004/diff/160001/ports/cairo/build.sh#n...
ports/cairo/build.sh:24: NACLPORTS_LDFLAGS+=" -lglibc-compat"
I think still needed, even after the .pc change?

https://codereview.chromium.org/1260083004/diff/160001/ports/gtk+/build.sh
File ports/gtk+/build.sh (right):

https://codereview.chromium.org/1260083004/diff/160001/ports/gtk+/build.sh#ne...
ports/gtk+/build.sh:19: ${NACLPORTS_LIBDIR}/pkgconfig/glib-2.0.pc
This should go in the InstallStep of the glib package

https://codereview.chromium.org/1260083004/diff/160001/ports/libx11/build.sh
File ports/libx11/build.sh (right):

https://codereview.chromium.org/1260083004/diff/160001/ports/libx11/build.sh#...
ports/libx11/build.sh:8: NACLPORTS_LDFLAGS+=" -lglibc-compat"
I think you can remove this now.

https://codereview.chromium.org/1260083004/diff/160001/ports/libxcb/build.sh
File ports/libxcb/build.sh (right):

https://codereview.chromium.org/1260083004/diff/160001/ports/libxcb/build.sh#...
ports/libxcb/build.sh:7: NACLPORTS_LDFLAGS+=" -lglibc-compat"
Ditto

[zhitingzhu, 2015-07-31 22:08:44]

The CQ bit was unchecked by zhitingzhu@google.com

[zhitingzhu, 2015-08-01 00:48:15]

https://codereview.chromium.org/1260083004/diff/160001/ports/cairo/build.sh
File ports/cairo/build.sh (right):

https://codereview.chromium.org/1260083004/diff/160001/ports/cairo/build.sh#n...
ports/cairo/build.sh:24: NACLPORTS_LDFLAGS+=" -lglibc-compat"
On 2015/07/31 22:07:00, Sam Clegg wrote:
> I think still needed, even after the .pc change?

Done.

https://codereview.chromium.org/1260083004/diff/160001/ports/gtk+/build.sh
File ports/gtk+/build.sh (right):

https://codereview.chromium.org/1260083004/diff/160001/ports/gtk+/build.sh#ne...
ports/gtk+/build.sh:19: ${NACLPORTS_LIBDIR}/pkgconfig/glib-2.0.pc
On 2015/07/31 22:07:00, Sam Clegg wrote:
> This should go in the InstallStep of the glib package

Done.

https://codereview.chromium.org/1260083004/diff/160001/ports/libx11/build.sh
File ports/libx11/build.sh (right):

https://codereview.chromium.org/1260083004/diff/160001/ports/libx11/build.sh#...
ports/libx11/build.sh:8: NACLPORTS_LDFLAGS+=" -lglibc-compat"
On 2015/07/31 22:07:00, Sam Clegg wrote:
> I think you can remove this now.

Done.

https://codereview.chromium.org/1260083004/diff/160001/ports/libxcb/build.sh
File ports/libxcb/build.sh (right):

https://codereview.chromium.org/1260083004/diff/160001/ports/libxcb/build.sh#...
ports/libxcb/build.sh:7: NACLPORTS_LDFLAGS+=" -lglibc-compat"
On 2015/07/31 22:07:00, Sam Clegg wrote:
> Ditto

Done.

[zhitingzhu, 2015-08-01 00:48:29]

The CQ bit was checked by zhitingzhu@google.com

[zhitingzhu, 2015-08-01 00:48:30]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/1260083004/#ps180001
(title: "update on comments")

[commit-bot: I haz the power, 2015-08-01 00:48:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083004/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083004/180001

[commit-bot: I haz the power, 2015-08-01 03:11:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-01 03:11:10]

Try jobs failed on following builders:
  naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...)

[zhitingzhu, 2015-08-01 21:42:40]

The CQ bit was checked by zhitingzhu@google.com

[zhitingzhu, 2015-08-01 21:42:41]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/1260083004/#ps200001
(title: "fix wrong c++ lib")

[commit-bot: I haz the power, 2015-08-01 21:42:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260083004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260083004/200001

[commit-bot: I haz the power, 2015-08-03 05:25:19]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/external/naclports/+/defa2be0fe3bcb5987b64d...