Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1260033005: Revert of Move net::FormatUrl and friends outside of //net and into //components (Closed)

Created:
5 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 4 months ago
CC:
asanka, benjhayden+dwatch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, gcasto+watchlist_chromium.org, jochen+watch_chromium.org, jshin+watch_chromium.org, markusheintz_, mcasas+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-notifications_chromium.org, mlamouri+watch-permissions_chromium.org, mlamouri+watch-geolocation_chromium.org, mlamouri+watch-content_chromium.org, Michael van Ouwerkerk, nasko+codewatch_chromium.org, noyau+watch_chromium.org, peter+watch_chromium.org, posciak+watch_chromium.org, James Su, tfarina, toyoshim+midi_chromium.org, vabr+watchlist_chromium.org, wjia+watch_chromium.org, Miguel Garcia
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move net::FormatUrl and friends outside of //net and into //components (patchset #16 id:290001 of https://codereview.chromium.org/1171333003/ ) Reason for revert: breaks gn_check on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/28796/steps/gn_check/logs/stdio Original issue's description: > Move net::FormatUrl and friends outside of //net and into //components > > net::FormatUrl and related are specifically concerned with display > policies of URLs, which is not something that //net needs to be aware > of, as that's a UX question. > > This folds in net::FormatURL along with the existing //components/url_fixer > and //components/secure_display into a common component, > //components/url_formatter, that handles reformatting URLs for user-friendly > or data storage (url_formatter), for use in security prompts (elide_url), > or for reformatting URLs from user input (url_fixer) > > (Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups) > > BUG=486979 > NOPRESUBMIT=true > > Committed: https://crrev.com/1659865c3eb47166c82378bb840801135b057a09 > Cr-Commit-Position: refs/heads/master@{#341605} TBR=droger@chromium.org,jam@chromium.org,mkwst@chromium.org,pkasting@chromium.org,sky@chromium.org,stuartmorgan@chromium.org,felt@chromium.org,rsleevi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=486979 Committed: https://crrev.com/90437dd218ba09f01612ebfc47eda167d67fb368 Cr-Commit-Position: refs/heads/master@{#341691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4465 lines, -4540 lines) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/url_utilities.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/browser_about_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_quota_permission_context.cc View 3 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_distiller/tab_utils_android.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/download/download_query.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/geolocation_infobar_delegate.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/interstitials/security_interstitial_page.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/media/media_stream_capture_indicator.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/media/midi_permission_infobar_delegate.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_infobar_delegate.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notification_permission_infobar_delegate.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/pepper_broker_infobar_delegate.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/permissions/permission_bubble_request_impl.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/policy/managed_bookmarks_policy_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/url_blacklist_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/captive_portal_blocking_page.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_bookmarks_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/edit_search_engine_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/startup_pages_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_utility.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/localized_error.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/net/url_util.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/common/net/x509_certificate_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/bookmarks_file_importer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download
M components/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/app_modal.gypi View 1 chunk +2 lines, -3 lines 0 comments Download
M components/app_modal/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/app_modal/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/app_modal/javascript_dialog_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/bookmarks.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/bookmarks/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/bookmarks/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_utils.h View 1 chunk +6 lines, -6 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils.cc View 3 chunks +12 lines, -13 lines 0 comments Download
M components/components.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 9 chunks +10 lines, -7 lines 0 comments Download
M components/content_settings.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings/core/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings/core/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_usages_state.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/error_page.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/error_page/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/error_page/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/error_page/renderer/net_error_helper_core.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M components/google.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/google/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/google/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/google/core/browser/google_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/history.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/history/core/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/history/core/browser/url_database.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M components/omnibox.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/autocomplete_input.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M components/omnibox/browser/autocomplete_match.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/omnibox/browser/autocomplete_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/autocomplete_result.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/bookmark_provider.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/omnibox/browser/builtin_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/history_quick_provider.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M components/omnibox/browser/history_url_provider.cc View 5 chunks +15 lines, -19 lines 0 comments Download
M components/omnibox/browser/search_provider.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M components/omnibox/browser/search_suggestion_parser.cc View 4 chunks +13 lines, -24 lines 0 comments Download
M components/omnibox/browser/shortcuts_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/url_index_private_data.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/omnibox/browser/zero_suggest_provider.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/password_manager.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M components/password_manager/core/browser/affiliation_utils.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M components/policy/core/browser/url_blacklist_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/search_engines/template_url_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A components/secure_display.gypi View 1 chunk +26 lines, -0 lines 0 comments Download
A components/secure_display/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download
A components/secure_display/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A components/secure_display/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A components/secure_display/elide_url.h View 1 chunk +72 lines, -0 lines 0 comments Download
A components/secure_display/elide_url.cc View 1 chunk +353 lines, -0 lines 0 comments Download
A components/secure_display/elide_url_unittest.cc View 1 chunk +324 lines, -0 lines 0 comments Download
A components/url_fixer.gypi View 1 chunk +27 lines, -0 lines 0 comments Download
A components/url_fixer/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A components/url_fixer/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A components/url_fixer/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A components/url_fixer/url_fixer.h View 1 chunk +87 lines, -0 lines 0 comments Download
A components/url_fixer/url_fixer.cc View 1 chunk +681 lines, -0 lines 0 comments Download
A components/url_fixer/url_fixer_unittest.cc View 1 chunk +536 lines, -0 lines 0 comments Download
D components/url_formatter/BUILD.gn View 1 chunk +0 lines, -51 lines 0 comments Download
D components/url_formatter/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D components/url_formatter/OWNERS View 1 chunk +0 lines, -9 lines 0 comments Download
D components/url_formatter/elide_url.h View 1 chunk +0 lines, -72 lines 0 comments Download
D components/url_formatter/elide_url.cc View 1 chunk +0 lines, -353 lines 0 comments Download
D components/url_formatter/elide_url_unittest.cc View 1 chunk +0 lines, -324 lines 0 comments Download
D components/url_formatter/url_fixer.h View 1 chunk +0 lines, -87 lines 0 comments Download
D components/url_formatter/url_fixer.cc View 1 chunk +0 lines, -673 lines 0 comments Download
D components/url_formatter/url_fixer_unittest.cc View 1 chunk +0 lines, -537 lines 0 comments Download
D components/url_formatter/url_formatter.h View 1 chunk +0 lines, -155 lines 0 comments Download
D components/url_formatter/url_formatter.cc View 1 chunk +0 lines, -807 lines 0 comments Download
D components/url_formatter/url_formatter.gyp View 1 chunk +0 lines, -39 lines 0 comments Download
D components/url_formatter/url_formatter_unittest.cc View 1 chunk +0 lines, -978 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/save_package.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_javascript_dialog_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/web/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/navigation/navigation_item_impl.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 3 chunks +2 lines, -3 lines 0 comments Download
M net/base/net_util.h View 3 chunks +116 lines, -0 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/base/net_util_icu.cc View 4 chunks +788 lines, -4 lines 0 comments Download
M net/base/net_util_icu_unittest.cc View 3 chunks +1029 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Move net::FormatUrl and friends outside of //net and into //components
5 years, 4 months ago (2015-08-04 07:03:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260033005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260033005/1
5 years, 4 months ago (2015-08-04 07:03:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 07:05:28 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 07:06:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90437dd218ba09f01612ebfc47eda167d67fb368
Cr-Commit-Position: refs/heads/master@{#341691}

Powered by Google App Engine
This is Rietveld 408576698