Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: ios/public/provider/chrome/browser/search_provider.h

Issue 1260033003: Partially componentize //chrome/browser/search/search.{h,cc} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/public/provider/chrome/browser/search_provider.h
diff --git a/ios/public/provider/chrome/browser/search_provider.h b/ios/public/provider/chrome/browser/search_provider.h
index cb639bf4feb8f9ef4838487dc52bf52bc9f93d84..76b959208d95d8ef931ff222fc2f03958f90b4d1 100644
--- a/ios/public/provider/chrome/browser/search_provider.h
+++ b/ios/public/provider/chrome/browser/search_provider.h
@@ -17,30 +17,6 @@ class SearchProvider {
SearchProvider() {}
virtual ~SearchProvider() {}
- // Returns whether query extraction is enabled.
- virtual bool IsQueryExtractionEnabled() = 0;
-
- // Returns a string indicating whether InstantExtended is enabled, suitable
- // for adding as a query parameter to the search requests. Returns an empty
- // string otherwise.
- //
- // |for_search| should be set to true for search requests, in which case this
- // returns a non-empty string only if query extraction is enabled.
- virtual std::string InstantExtendedEnabledParam(bool for_search) = 0;
-
- // Returns a string that will cause the search results page to update
- // incrementally. Currently, Instant Extended passes a different param to
- // search results pages that also has this effect, so by default this function
- // returns the empty string when Instant Extended is enabled. However, when
- // doing instant search result prerendering, we still need to pass this param,
- // as Instant Extended does not cause incremental updates by default for the
- // prerender page. Callers should set |for_prerender| in this case to force
- // the returned string to be non-empty.
- virtual std::string ForceInstantResultsParam(bool for_prerender) = 0;
-
- // Returns the start-edge margin of the omnibox in pixels.
- virtual int OmniboxStartMargin() = 0;
-
// Returns the value to use for replacements of type
// GOOGLE_IMAGE_SEARCH_SOURCE.
virtual std::string GoogleImageSearchSource() = 0;

Powered by Google App Engine
This is Rietveld 408576698