chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 1260033003: Partially componentize //chrome/browser/search/search.{h,cc}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 1260033003: Partially componentize //chrome/browser/search/search.{h,cc} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_model_unittest.cc ('k') | chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc » ('j') | components/search/search.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index adc7bd44d96f06676ae0eb9947e51719b30dafb7..b32f509fdc1069dfb9d79cc3a82a8460388bb13b 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -28,6 +28,7 @@

#include "components/omnibox/browser/autocomplete_input.h"

#include "components/omnibox/browser/autocomplete_match.h"

#include "components/omnibox/browser/omnibox_field_trial.h"

+#include "components/search/search.h"

#include "content/public/browser/web_contents.h"

#include "extensions/common/constants.h"

#include "net/base/escape.h"

@@ -1058,7 +1059,7 @@ void OmniboxViewViews::UpdateContextMenu(ui::SimpleMenuModel* menu_contents) {

menu_contents->AddSeparator(ui::NORMAL_SEPARATOR);

- if (chrome::IsQueryExtractionEnabled()) {

+ if (search::IsQueryExtractionEnabled()) {

int select_all_position = menu_contents->GetIndexOfCommandId(

IDS_APP_SELECT_ALL);

DCHECK_GE(select_all_position, 0);