chrome/browser/ui/search/instant_controller.cc - Issue 1260033003: Partially componentize //chrome/browser/search/search.{h,cc}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/instant_controller.cc

Issue 1260033003: Partially componentize //chrome/browser/search/search.{h,cc} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation on iOS Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/omnibox/chrome_omnibox_client.cc ('k') | chrome/browser/ui/search/instant_extended_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/instant_controller.cc

diff --git a/chrome/browser/ui/search/instant_controller.cc b/chrome/browser/ui/search/instant_controller.cc

index 26c0917eef95a10536082fb47a6748ffe26739ae..33020d5fa69b8c0813850691d80725c479af987c 100644

--- a/chrome/browser/ui/search/instant_controller.cc

+++ b/chrome/browser/ui/search/instant_controller.cc

@@ -47,7 +47,7 @@ void EnsureSearchTermsAreSet(content::WebContents* contents,

// If search terms are already correct or there is already a transient entry

// (there shouldn't be), bail out early.

- if (chrome::GetSearchTerms(contents) == search_terms ||

+ if (search::GetSearchTerms(contents) == search_terms ||

controller->GetTransientEntry())

return;

@@ -108,7 +108,7 @@ void InstantController::ActiveTabChanged() {

void InstantController::TabDeactivated(content::WebContents* contents) {

// If user is deactivating an NTP tab, log the number of mouseovers for this

// NTP session.

- if (chrome::IsInstantNTP(contents))

+ if (search::IsInstantNTP(contents))

InstantTab::EmitNtpStatistics(contents);

}