Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: chrome/browser/ui/browser_instant_controller.cc

Issue 1260033003: Partially componentize //chrome/browser/search/search.{h,cc} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation on iOS Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/browser_instant_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_instant_controller.cc
diff --git a/chrome/browser/ui/browser_instant_controller.cc b/chrome/browser/ui/browser_instant_controller.cc
index c4871ef162c7cbfbd3767f5faedf01075bd77aa5..8344448f5904d55a508c3cfa4a2b6b0dc989e7d5 100644
--- a/chrome/browser/ui/browser_instant_controller.cc
+++ b/chrome/browser/ui/browser_instant_controller.cc
@@ -75,7 +75,7 @@ bool BrowserInstantController::OpenInstant(WindowOpenDisposition disposition,
DCHECK(disposition == CURRENT_TAB) << disposition;
const base::string16& search_terms =
- chrome::ExtractSearchTermsFromURL(profile(), url);
+ search::ExtractSearchTermsFromURL(profile(), url);
EmbeddedSearchRequestParams request_params(url);
if (search_terms.empty())
return false;
@@ -95,7 +95,7 @@ bool BrowserInstantController::OpenInstant(WindowOpenDisposition disposition,
// If we will not be replacing search terms from this URL, don't send to
// InstantController.
- if (!chrome::IsQueryExtractionAllowedForURL(profile(), url))
+ if (!search::IsQueryExtractionAllowedForURL(profile(), url))
return false;
return instant_.SubmitQuery(search_terms, request_params);
}
@@ -166,8 +166,8 @@ void BrowserInstantController::DefaultSearchProviderChanged(
if (google_base_url_domain_changed &&
SearchTabHelper::FromWebContents(contents)->model()->mode().is_ntp()) {
// Replace the server NTP with the local NTP.
- content::NavigationController::LoadURLParams
- params(chrome::GetLocalInstantURL(profile()));
+ content::NavigationController::LoadURLParams params(
+ search::GetLocalInstantURL(profile()));
params.should_replace_current_entry = true;
params.referrer = content::Referrer();
params.transition_type = ui::PAGE_TRANSITION_RELOAD;
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/browser_instant_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698