Provide metadata to validator to allow faster caching.

src/trusted/validator/x86/32/ncvalidate.c

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /* Implement the ApplyValidator API for the x86-32 architecture. */
 
 #include "native_client/src/trusted/validator/ncvalidate.h"
 #include "native_client/src/trusted/validator/validation_cache.h"
@@ skipping 12 matching lines @@
 # endif
 #endif
 
 static NaClValidationStatus ApplyValidator_x86_32(
     uintptr_t guest_addr,
     uint8_t *data,
     size_t size,
     int stubout_mode,
     int readonly_text,
     const NaClCPUFeatures *f,
+    const struct NaClValidationMetadata *metadata,
     struct NaClValidationCache *cache) {
   /* TODO(jfb) Use a safe cast here. */
   const NaClCPUFeaturesX86 *cpu_features = (NaClCPUFeaturesX86 *) f;
   struct NCValidatorState *vstate;
   int validator_result = 0;
   void *query = NULL;
 
   /* Check that the given parameter values are supported. */
   if (stubout_mode && readonly_text)
     return NaClValidationFailedNotImplemented;
 
   if (!NaClArchSupportedX86(cpu_features))
     return NaClValidationFailedCpuNotSupported;
 
   /* Don't cache in stubout mode. */
   if (stubout_mode)
     cache = NULL;
 
   /* If the validation caching interface is available, perform a query. */
   if (cache != NULL)
     query = cache->CreateQuery(cache->handle);
   if (query != NULL) {
     const char validator_id[] = "x86-32";
     cache->AddData(query, (uint8_t *) validator_id, sizeof(validator_id));
     cache->AddData(query, (uint8_t *) cpu_features, sizeof(*cpu_features));
-    cache->AddData(query, data, size);
+    AddCodeIdentity(data, size, metadata, cache, query);
     if (cache->QueryKnownToValidate(query)) {
       cache->DestroyQuery(query);
       return NaClValidationSucceeded;
     }
   }
 
   /* Init then validator state. */
   /* TODO(ncbray) make "detailed" a parameter. */
   if (stubout_mode) {
     vstate = NCValidateInitDetailed(guest_addr, size, cpu_features);
@@ skipping 101 matching lines @@
   ApplyValidatorCodeReplacement_x86_32,
   sizeof(NaClCPUFeaturesX86),
   NaClSetAllCPUFeaturesX86,
   NaClGetCurrentCPUFeaturesX86,
   NaClFixCPUFeaturesX86,
 };
 
 const struct NaClValidatorInterface *NaClValidatorCreate_x86_32(void) {
   return &validator;
 }