Move Service Worker %2f validation logic from browser into Blink (2)

Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Index: Source/modules/serviceworkers/ServiceWorkerContainer.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
index cbb117f1608a182fa1b5eb6f6cb283d14054f27d..715f6532bdee5761e74e2f040bf28543a8607acc 100644
--- a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
@@ -35,6 +35,7 @@
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/SerializedScriptValue.h"
 #include "bindings/core/v8/SerializedScriptValueFactory.h"
+#include "bindings/core/v8/V8ThrowException.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
@@ -246,6 +247,12 @@ ScriptPromise ServiceWorkerContainer::registerServiceWorker(ScriptState* scriptS
         return promise;
     }
 
+    WebString webErrorMessage;
+    if (!m_provider->validateScopeAndScriptURL(patternURL, scriptURL, &webErrorMessage)) {

[falken, 2015/08/05 06:54:23]

Ah it's kind of weird that validateScopeAndScript is a non-static function on
m_provider, it's just a static check that has nothing to do with the m_provider
instance. I guess we had to to this to allow blink code to call into chromium.
Is there a better way?

I can't think of one, so won't block this, but just wanted to raise the
question.

[nhiroki, 2015/08/05 07:15:09]

Ah, good point. Moving validateSASURL into Platform.h could be an option?

[nhiroki, 2015/08/05 07:31:58]

I had an offline chat w/ jeremy and falken. We decided to keep this as is
because either way we cannot make this static.

+        resolver->reject(V8ThrowException::createTypeError(scriptState->isolate(), WebString::fromUTF8("Failed to register a ServiceWorker: " + webErrorMessage.utf8())));
+        return promise;
+    }
+
     m_provider->registerServiceWorker(patternURL, scriptURL, new RegistrationCallback(resolver));
 
     return promise;