public/platform/WebServiceWorkerProvider.h - Issue 1260003003: Move Service Worker %2f validation logic from browser into Blink (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebServiceWorkerProvider.h

Issue 1260003003: Move Service Worker %2f validation logic from browser into Blink (2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix compile error (!) in original patch. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebServiceWorkerProvider.h

diff --git a/public/platform/WebServiceWorkerProvider.h b/public/platform/WebServiceWorkerProvider.h

index 6cdd21dbb036accfb8c497fd11a02fcf4bb27b19..979b1cd7e41e8046feacae18571c4ef12c1abaa2 100644

--- a/public/platform/WebServiceWorkerProvider.h

+++ b/public/platform/WebServiceWorkerProvider.h

@@ -62,6 +62,7 @@ public:

virtual void getRegistration(const WebURL& documentURL, WebServiceWorkerGetRegistrationCallbacks*) { }

virtual void getRegistrations(WebServiceWorkerGetRegistrationsCallbacks*) { }

virtual void getRegistrationForReady(WebServiceWorkerGetRegistrationForReadyCallbacks*) { }

+ virtual bool validateScopeAndScriptURL(const WebURL& scope, const WebURL& scriptURL, WebString* errorMessage);

nhiroki 2015/07/31 08:47:32 Can you add "{ return false; }"?

virtual ~WebServiceWorkerProvider() { }

};

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp ('k') | no next file » | no next file with comments »