Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: content/browser/loader/resource_scheduler_unittest.cc

Issue 12600018: ResourceScheduler should use renderer notifications instead of MRUCache to track renderers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reverse destruction order Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_scheduler_unittest.cc
diff --git a/content/browser/loader/resource_scheduler_unittest.cc b/content/browser/loader/resource_scheduler_unittest.cc
index 1e543b477c1ae5c2a32d2c7f43da83166e9a096c..be112414dd8e5d58a0bb2352e7f428407d3be06b 100644
--- a/content/browser/loader/resource_scheduler_unittest.cc
+++ b/content/browser/loader/resource_scheduler_unittest.cc
@@ -80,10 +80,11 @@ class ResourceSchedulerTest : public testing::Test {
ResourceSchedulerTest()
: message_loop_(MessageLoop::TYPE_IO),
ui_thread_(BrowserThread::UI, &message_loop_) {
- scheduler_.OnNavigate(kChildId, kRouteId);
+ scheduler_.OnClientCreated(kChildId, kRouteId);
}
virtual ~ResourceSchedulerTest() {
+ scheduler_.OnClientDeleted(kChildId, kRouteId);
}
scoped_ptr<net::URLRequest> NewURLRequest(const char* url,
@@ -168,20 +169,6 @@ TEST_F(ResourceSchedulerTest, StartRequestsWhenIdle) {
EXPECT_TRUE(low->started());
}
-TEST_F(ResourceSchedulerTest, EvictedClientsIssuePendingRequests) {
- ScopedVector<TestRequest> low_requests;
- ScopedVector<TestRequest> high_requests;
- for (int i = 0; i < 6; i++) {
- scheduler_.OnNavigate(kChildId, kRouteId + i);
- high_requests.push_back(
- NewRequest("http://host/i", net::HIGHEST, kRouteId + i));
- low_requests.push_back(
- NewRequest("http://host/i", net::LOWEST, kRouteId + i));
- EXPECT_FALSE(low_requests[i]->started());
- }
- EXPECT_TRUE(low_requests[0]->started());
-}
-
TEST_F(ResourceSchedulerTest, CancelOtherRequestsWhileResuming) {
scoped_ptr<TestRequest> high(NewRequest("http://host/high", net::HIGHEST));
scoped_ptr<TestRequest> low1(NewRequest("http://host/low1", net::LOWEST));
« no previous file with comments | « content/browser/loader/resource_scheduler.cc ('k') | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698