Issue 12600004: Simplify PreParser::ParsePrimaryExpression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12600004: Simplify PreParser::ParsePrimaryExpression (Closed)

Created:
7 years, 9 months ago by wingo

Modified:
7 years, 9 months ago

Reviewers:
rossberg, Michael Starzinger

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Simplify PreParser::ParsePrimaryExpression * src/preparser.cc (PreParser::ParsePrimaryExpression): No need to check keywords for validity as identifiers, as ParseIdentifier (called in the fallthrough) will take care of it. Covered by existing tests. BUG= Committed: http://code.google.com/p/v8/source/detail?r=13899

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -17 lines)			Patch
	M	src/preparser.cc	View		1 chunk	+1 line, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 9 months ago (2013-03-11 12:44:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13899 (presubmit successful).

Expand Messages | Collapse Messages