Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 12600003: MIPS: fix NaN handling of Isolate::StackOverflow() (Closed)

Created:
7 years, 9 months ago by kilvadyb
Modified:
7 years, 9 months ago
Reviewers:
kisg, Paul Lind, palfia, danno, Yang
CC:
v8-dev
Visibility:
Public.

Description

MIPS: fix NaN handling of Isolate::StackOverflow() The mjsunit/stack-traces-overflow.js test fails on MIPS target as Error.stackTraceLimit = NaN; should disable stack trace messages and Isolate::StackOverflow() assumes static_cast<int>(double NaN) < 0. MIPS has a different NaN representation than other architectures so the NaN value casted to int is positive. This patch adds an isnan() check to make the handling of NaN uniform on all architectures. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/isolate.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 9 months ago (2013-03-11 12:26:47 UTC) #1
Yang
On 2013/03/11 12:26:47, kilvadyb wrote: LGTM.
7 years, 9 months ago (2013-03-11 12:28:10 UTC) #2
palfia
7 years, 9 months ago (2013-03-11 13:35:33 UTC) #3
Committed as r13900.

Powered by Google App Engine
This is Rietveld 408576698