Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1259973002: Canvas2d: Remove unnecessary conversion in EventHitRegion. (Closed)

Created:
5 years, 4 months ago by zino
Modified:
5 years, 3 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, dshwang, Rik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Canvas2d: Remove unnecessary conversion in EventHitRegion. We don't need the conversion. - Before : FloatPoint -> LayoutPoint -> FloatPoint - After : FloatPoint Also, remove the |contains(LayoutPoint)| method. BUG=none TEST=existing tests (this change doesn't affect any behavior) Committed: https://crrev.com/b8387cadf9603622939490b22623281afb7779d7 git-svn-id: svn://svn.chromium.org/blink/trunk@199545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/canvas2d/EventHitRegion.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/modules/canvas2d/HitRegion.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/canvas2d/HitRegion.cpp View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
zino
5 years, 4 months ago (2015-07-27 12:45:12 UTC) #2
zino
Please take a look. This is a trivial cleanup. Thank you.
5 years, 4 months ago (2015-07-27 12:46:34 UTC) #3
Justin Novosad
On 2015/07/27 12:46:34, zino wrote: > Please take a look. > > This is a ...
5 years, 4 months ago (2015-07-27 15:24:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259973002/1
5 years, 4 months ago (2015-07-28 00:12:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199545
5 years, 4 months ago (2015-07-28 01:30:21 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:49:39 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b8387cadf9603622939490b22623281afb7779d7

Powered by Google App Engine
This is Rietveld 408576698