Issue 1259953004: update presubmit to know about include/private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1259953004: update presubmit to know about include/private (Closed)

Created:
5 years, 4 months ago by mtklein_C

Modified:
5 years, 4 months ago

Reviewers:
bungeman-skia, rmistry, mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

update presubmit to know about include/private BUG=skia:4126 Committed: https://skia.googlesource.com/skia/+/bda12677704bc1c19b156236f4f8b08d2fb0b4fc

Patch Set 1 #

Patch Set 2 : sp #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	PRESUBMIT.py	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259953004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259953004/20001

5 years, 4 months ago (2015-07-28 14:56:48 UTC) #7

commit-bot: I haz the power

5 years, 4 months ago (2015-07-28 15:54:16 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bda12677704bc1c19b156236f4f8b08d2fb0b4fc

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages