Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1259943002: collectLayerFragments() expects a dirty rect relative to the multicol container. (Closed)

Created:
5 years, 5 months ago by mstensho (USE GERRIT)
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

collectLayerFragments() expects a dirty rect relative to the multicol container. It was actually relative to the flow thread (see call site at DeprecatedPaintLayer::collectFragments()), but it's documented as "relative to the multicol container" in MultiColumnFragmentainerGroup::collectLayerFragments(). So make it relative to the multicol container, then. There was no layout test to catch this fundamental RTL issue, so I added one. BUG=511655 R=dsinclair@chromium.org,jchaffraix@chromium.org,leviw@chromium.org Committed: https://crrev.com/988434c70468340b0be273fb7a0a8f3094bb0852 git-svn-id: svn://svn.chromium.org/blink/trunk@199697 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
A LayoutTests/fast/multicol/basic-rtl.html View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/basic-rtl-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutFlowThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutFlowThread.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
mstensho (USE GERRIT)
5 years, 5 months ago (2015-07-27 11:08:02 UTC) #2
mstensho (USE GERRIT)
5 years, 4 months ago (2015-07-29 08:09:44 UTC) #4
leviw_travelin_and_unemployed
lgtm Great layout test :) Just an FYI: dsinclair mostly doesn't work on the project ...
5 years, 4 months ago (2015-07-29 23:55:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259943002/1
5 years, 4 months ago (2015-07-29 23:55:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199697
5 years, 4 months ago (2015-07-30 02:25:52 UTC) #8
mstensho (USE GERRIT)
On 2015/07/29 23:55:30, leviw wrote: > Just an FYI: dsinclair mostly doesn't work on the ...
5 years, 4 months ago (2015-07-30 05:45:21 UTC) #9
dsinclair
On 2015/07/30 05:45:21, mstensho wrote: > On 2015/07/29 23:55:30, leviw wrote: > > Just an ...
5 years, 4 months ago (2015-08-05 15:03:42 UTC) #10
mstensho (USE GERRIT)
On 2015/08/05 15:03:42, dsinclair wrote: > On 2015/07/30 05:45:21, mstensho wrote: > > On 2015/07/29 ...
5 years, 4 months ago (2015-08-05 16:06:49 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:54:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/988434c70468340b0be273fb7a0a8f3094bb0852

Powered by Google App Engine
This is Rietveld 408576698