Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1259913003: MacViews: Implement Tab Dragging (Closed)

Created:
5 years, 4 months ago by tapted
Modified:
4 years, 4 months ago
Reviewers:
Lof
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@20150529-ViewsBrowser-DisableCertificateDialog
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Implement Tab Dragging Looks like it's actually not too hard to *improve* on Cocoa and actually allow the window to be dragged between spaces straight from a tab. We'll see. BUG=

Patch Set 1 #

Patch Set 2 : EndMoveLoop, GetLocalProcessWindow tweak, more tracing, OnPositionChanged, ... #

Patch Set 3 : More progress #

Patch Set 4 : OMG it all works :o #

Patch Set 5 : Encapsulation. Handle Window being deleted under us. #

Patch Set 6 : update comments, still a TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -13 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 2 11 chunks +42 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_mac.mm View 1 1 chunk +26 lines, -2 lines 0 comments Download
M ui/events/cocoa/events_mac.mm View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M ui/views/cocoa/bridged_content_view.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M ui/views/cocoa/bridged_content_view.mm View 1 2 3 6 chunks +22 lines, -1 line 0 comments Download
M ui/views/cocoa/bridged_native_widget.h View 1 2 3 4 6 chunks +14 lines, -0 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 1 2 3 4 5 10 chunks +245 lines, -0 lines 0 comments Download
M ui/views/cocoa/views_nswindow_delegate.mm View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac.mm View 1 2 3 5 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lof
Hi tapted! Why isn't this CL completed? Is there any serious problems? Or just need ...
4 years, 10 months ago (2016-02-18 11:05:14 UTC) #2
tapted
On 2016/02/18 11:05:14, Lof wrote: > Hi tapted! > > Why isn't this CL completed? ...
4 years, 10 months ago (2016-02-18 11:16:56 UTC) #3
themblsha
4 years, 10 months ago (2016-02-18 15:34:32 UTC) #4
On 2016/02/18 11:16:56, tapted wrote:
> It also needs some tests :/

I added tests for tab drag&drop in Yandex.Browser, and I think I can adapt them
to the MacViews. Would be a nice opportunity to upstream some helper functions
that are sending CG events directly.

Powered by Google App Engine
This is Rietveld 408576698