Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: components/tracing.gyp

Issue 12599004: components: Fix components_tracing.gyp to follow the same pattern of the other gyp files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: include comment about it Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/components_tracing_untrusted.gyp ('k') | components/tracing_untrusted.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing.gyp
diff --git a/components/components_tracing.gyp b/components/tracing.gyp
similarity index 70%
rename from components/components_tracing.gyp
rename to components/tracing.gyp
index f11c823de077b96577d0e82b98ee54fc7aa084f5..fe7e588f3ff65327e8202241c70b6fc5e288135e 100644
--- a/components/components_tracing.gyp
+++ b/components/tracing.gyp
@@ -3,6 +3,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+# This file is intentionally a gyp file rather than a gypi for dependencies
+# reasons. The other gypi files include content.gyp and content_common depends
+# on this, thus if you try to rename this to gypi and include it in
+# components.gyp, you will get a circular dependency error.
{
'targets' : [
{
« no previous file with comments | « components/components_tracing_untrusted.gyp ('k') | components/tracing_untrusted.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698