Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1259893006: Hack around dart:io being loaded into non-service isolates in Dartium. (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Hack around dart:io being loaded into non-service isolates in Dartium. BUG=http://dartbug.com/23940 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/db8ed04981aee7e656fa96db161733e01a260649

Patch Set 1 #

Total comments: 2

Patch Set 2 : thread api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M runtime/lib/mirrors.cc View 1 2 chunks +20 lines, -3 lines 0 comments Download
A tests/lib/mirrors/io_html_mutual_exclusion_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-03 19:57:56 UTC) #2
siva
lgtm https://codereview.chromium.org/1259893006/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/1259893006/diff/1/runtime/lib/mirrors.cc#newcode389 runtime/lib/mirrors.cc:389: Isolate* isolate = Isolate::Current(); We are trying to ...
5 years, 4 months ago (2015-08-03 23:37:22 UTC) #3
rmacnak
https://codereview.chromium.org/1259893006/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/1259893006/diff/1/runtime/lib/mirrors.cc#newcode389 runtime/lib/mirrors.cc:389: Isolate* isolate = Isolate::Current(); On 2015/08/03 23:37:21, siva wrote: ...
5 years, 4 months ago (2015-08-03 23:59:20 UTC) #4
rmacnak
5 years, 4 months ago (2015-08-03 23:59:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
db8ed04981aee7e656fa96db161733e01a260649 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698