Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Unified Diff: chrome/test/BUILD.gn

Issue 1259883007: Remove the Finch test 'CLD1VsCLD2' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 44c2c7493bcaa1b4d4fab4bc2ce7455517fd045d..ef9e19b5f8cfd6e9b57fba46981f72e6032c9e3b 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -406,7 +406,7 @@ if (!is_android) {
ldflags += [ "-Wl,-ObjC" ]
}
- if (cld_version == 0 || cld_version == 2) {
+ if (cld_version == 2) {
# Interactive tests should use whatever CLD2 data access mode that the
# application embedder is using.
deps += [ "//third_party/cld_2:cld2_platform_impl" ]
@@ -635,7 +635,7 @@ if (!is_android) {
# 'UseLibraryDependencyInputs': "true",
# }
- if (cld_version == 0 || cld_version == 2) {
+ if (cld_version == 2) {
# Because the browser_tests use translate, they need CLD data.
deps += [ "//third_party/cld_2:cld2_platform_impl" ]
}
@@ -1005,7 +1005,7 @@ if (!is_android) {
"//third_party/WebKit/public:blink",
]
- if (cld_version == 0 || cld_version == 2) {
+ if (cld_version == 2) {
# Language detection is irrelevant to sync, so it can depend on any
# implementation for CLD2. Dynamic is smaller, so go with dynamic.
deps += [ "//third_party/cld_2:cld2_dynamic" ]
@@ -1076,7 +1076,7 @@ if (!is_android) {
"//testing/gtest",
]
- if (cld_version == 0 || cld_version == 2) {
+ if (cld_version == 2) {
# Language detection is irrelevant to sync, so it can depend on any
# implementation for CLD2. Dynamic is smaller, so go with dynamic.
deps += [ "//third_party/cld_2:cld2_dynamic" ]
@@ -1500,7 +1500,7 @@ if (!is_android) {
} else {
sources -= [ "../browser/password_manager/password_store_x_unittest.cc" ]
}
- if (cld_version == 0 || cld_version == 2) {
+ if (cld_version == 2) {
# Unit tests should be independent of the CLD2 access mechanism, just use
# static for simplicity.
deps += [ "//third_party/cld_2:cld2_static" ]
@@ -1701,7 +1701,7 @@ if (!is_android) {
"//base/test:run_all_unittests",
"//base/test:test_support",
]
- if (cld_version == 0 || cld_version == 2) {
+ if (cld_version == 2) {
# Use whatever CLD2 data access mode that the
# application embedder is using.
deps += [ "//third_party/cld_2:cld2_platform_impl" ]
@@ -1748,7 +1748,7 @@ if (!is_android) {
sources -= [ "perf/mach_ports_performancetest.cc" ]
}
- if (cld_version == 0 || cld_version == 2) {
+ if (cld_version == 2) {
# Use whatever CLD2 data access mode that the
# application embedder is using.
deps += [ "//third_party/cld_2:cld2_platform_impl" ]

Powered by Google App Engine
This is Rietveld 408576698