build/config/BUILD.gn - Issue 1259883007: Remove the Finch test 'CLD1VsCLD2'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILD.gn

Issue 1259883007: Remove the Finch test 'CLD1VsCLD2' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILD.gn

diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn

index 2d1dd1ed7d4dbcf0184722fe87f9de3928d087c3..b824458a566dcd58a49bfaf3b67a2caf1858c39d 100644

--- a/build/config/BUILD.gn

+++ b/build/config/BUILD.gn

@@ -45,10 +45,7 @@ declare_args() {

config("feature_flags") {

# TODO(brettw) this probably needs to be parameterized.

defines = [ "V8_DEPRECATION_WARNINGS" ] # Don't use deprecated V8 APIs anywhere.

- if (cld_version > 0) {

- defines += [ "CLD_VERSION=$cld_version" ]

- }

+ defines += [ "CLD_VERSION=$cld_version" ]

Takashi Toyoshima 2015/07/30 08:41:05 defines = [ "V8...", # ... "CLD_..." ] may be

hajimehoshi 2015/07/30 08:51:29 Done.

if (enable_mdns) {

defines += [ "ENABLE_MDNS=1" ]

}