Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: build/config/BUILD.gn

Issue 1259883007: Remove the Finch test 'CLD1VsCLD2' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/crypto.gni") 7 import("//build/config/crypto.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 import("//build/config/ui.gni") 10 import("//build/config/ui.gni")
(...skipping 26 matching lines...) Expand all
37 37
38 # TODO(brettw) Most of these should be removed. Instead of global feature 38 # TODO(brettw) Most of these should be removed. Instead of global feature
39 # flags, we should have more modular flags that apply only to a target and its 39 # flags, we should have more modular flags that apply only to a target and its
40 # dependents. For example, depending on the "x11" meta-target should define 40 # dependents. For example, depending on the "x11" meta-target should define
41 # USE_X11 for all dependents so that everything that could use X11 gets the 41 # USE_X11 for all dependents so that everything that could use X11 gets the
42 # define, but anything that doesn't depend on X11 doesn't see it. 42 # define, but anything that doesn't depend on X11 doesn't see it.
43 # 43 #
44 # For now we define these globally to match the current GYP build. 44 # For now we define these globally to match the current GYP build.
45 config("feature_flags") { 45 config("feature_flags") {
46 # TODO(brettw) this probably needs to be parameterized. 46 # TODO(brettw) this probably needs to be parameterized.
47 defines = [ "V8_DEPRECATION_WARNINGS" ] # Don't use deprecated V8 APIs anywhe re. 47 defines = [
48 48 "V8_DEPRECATION_WARNINGS", # Don't use deprecated V8 APIs anywhere.
49 if (cld_version > 0) { 49 "CLD_VERSION=$cld_version",
50 defines += [ "CLD_VERSION=$cld_version" ] 50 ]
51 }
52 if (enable_mdns) { 51 if (enable_mdns) {
53 defines += [ "ENABLE_MDNS=1" ] 52 defines += [ "ENABLE_MDNS=1" ]
54 } 53 }
55 if (enable_notifications) { 54 if (enable_notifications) {
56 defines += [ "ENABLE_NOTIFICATIONS" ] 55 defines += [ "ENABLE_NOTIFICATIONS" ]
57 } 56 }
58 if (enable_pepper_cdms) { 57 if (enable_pepper_cdms) {
59 # TODO(brettw) should probably be "=1" 58 # TODO(brettw) should probably be "=1"
60 defines += [ "ENABLE_PEPPER_CDMS" ] 59 defines += [ "ENABLE_PEPPER_CDMS" ]
61 } 60 }
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 # with precompiled headers since the source file that's "compiled" for 437 # with precompiled headers since the source file that's "compiled" for
439 # making the precompiled header is empty. 438 # making the precompiled header is empty.
440 # 439 #
441 # This error doesn't happen every time. In VS2013, it seems if the .pch 440 # This error doesn't happen every time. In VS2013, it seems if the .pch
442 # file doesn't exist, no error will be generated (probably MS tested this 441 # file doesn't exist, no error will be generated (probably MS tested this
443 # case but forgot the other one?). To reproduce this error, do a build, 442 # case but forgot the other one?). To reproduce this error, do a build,
444 # then delete the precompile.c.obj file, then build again. 443 # then delete the precompile.c.obj file, then build again.
445 cflags_c = [ "/wd4206" ] 444 cflags_c = [ "/wd4206" ]
446 } 445 }
447 } 446 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | chrome/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698