Dart: Runs dartanalyzer for the dart_pkg build rule.

Dart: Runs dartanalyzer for the dart_pkg build rule.

- Changes the dart_pkg rule to take an 'entrypoints'
  parameter on which the analyzer will be invoked.
- Includes symlinks to all dependent packages in
  dart-pkg/packages, not just other dart-pkg packages.
- Takes the location of the Dart SDK from
  //build/module_args/dart.gni instead of hard-coding it in
  dart_analyze.py
- Fixes a couple analyzer reports.

BUG=
R=johnmccutchan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/402986f19a165b3be13108146a913245c2c36d7c

[zra, 2015-07-27 16:27:46]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[zra, 2015-07-27 16:27:47]

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
File mojo/public/tools/dart_pkg.py (right):

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
mojo/public/tools/dart_pkg.py:1: #!/usr/bin/env python
Changed 4 -> 2 space indents. Actual changes noted below.

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
mojo/public/tools/dart_pkg.py:164: def analyze_entrypoints(dart_sdk,
package_root, entrypoints):
New function for invoking dart_analyze.py

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
mojo/public/tools/dart_pkg.py:182: parser.add_argument('--dart-sdk',
New option for Dart SDK location.

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
mojo/public/tools/dart_pkg.py:211: parser.add_argument('--package-entrypoints',
New option for entrypoints.

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
mojo/public/tools/dart_pkg.py:302: # Symlink non-dart-pkg dependent packages
New code to symlink dependent packages not already in dart-pkg.

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
mojo/public/tools/dart_pkg.py:316: if entrypoint_targets != []:
New code to analyze entrypoints.

[Cutch, 2015-07-27 16:31:51]

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
File mojo/public/tools/dart_pkg.py (right):

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
mojo/public/tools/dart_pkg.py:1: #!/usr/bin/env python
On 2015/07/27 16:27:46, zra wrote:
> Changed 4 -> 2 space indents. Actual changes noted below.

https://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Indentation

[zra, 2015-07-27 16:52:31]

On 2015/07/27 16:31:51, Cutch wrote:
>
https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
> File mojo/public/tools/dart_pkg.py (right):
> 
>
https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
> mojo/public/tools/dart_pkg.py:1: #!/usr/bin/env python
> On 2015/07/27 16:27:46, zra wrote:
> > Changed 4 -> 2 space indents. Actual changes noted below.
> 
> https://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Indentation

Understood. However, this is the only python file in the mojo tree using 4 space
indents, so I'd favor consistency over correctness in this case.

[zra, 2015-07-27 16:55:03]

On 2015/07/27 16:31:51, Cutch wrote:
>
https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
> File mojo/public/tools/dart_pkg.py (right):
> 
>
https://codereview.chromium.org/1259873002/diff/40001/mojo/public/tools/dart_...
> mojo/public/tools/dart_pkg.py:1: #!/usr/bin/env python
> On 2015/07/27 16:27:46, zra wrote:
> > Changed 4 -> 2 space indents. Actual changes noted below.
> 
> https://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Indentation

Ah, yah. Also Chromium style says 2 space indents. That must be what Mojo is
following.

https://www.chromium.org/developers/coding-style

[Cutch, 2015-07-27 22:13:59]

lgtm

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/dart/rules.gni
File mojo/public/dart/rules.gni (right):

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/dart/rules....
mojo/public/dart/rules.gni:219: #   entrypoints (optional)
If this is optional it should go below.

[zra, 2015-07-27 22:46:49]

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/dart/rules.gni
File mojo/public/dart/rules.gni (right):

https://codereview.chromium.org/1259873002/diff/40001/mojo/public/dart/rules....
mojo/public/dart/rules.gni:219: #   entrypoints (optional)
On 2015/07/27 22:13:58, Cutch wrote:
> If this is optional it should go below.

Done.

[zra, 2015-07-27 22:47:19]

Committed patchset #4 (id:60001) manually as
402986f19a165b3be13108146a913245c2c36d7c (presubmit successful).