Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1259853002: Cross-script variables handling fixed. It was possible to write to read-only global variable. (Closed)

Created:
5 years, 4 months ago by Igor Sheludko
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cross-script variables handling fixed. It was possible to write to read-only global variable. Committed: https://crrev.com/156042f7f71effd101fbfb2ca1b5a2c3aec62079 Cr-Commit-Position: refs/heads/master@{#29860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+627 lines, -15 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A test/mjsunit/regress/cross-script-vars.js View 1 chunk +573 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL & CQ. We forgot add a cell validity check in StoreGlobalViaContext. I also wrote ...
5 years, 4 months ago (2015-07-25 16:34:51 UTC) #2
Benedikt Meurer
LGTM.
5 years, 4 months ago (2015-07-27 05:24:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259853002/1
5 years, 4 months ago (2015-07-27 05:24:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 05:53:04 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 05:53:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/156042f7f71effd101fbfb2ca1b5a2c3aec62079
Cr-Commit-Position: refs/heads/master@{#29860}

Powered by Google App Engine
This is Rietveld 408576698