Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1259823002: Remove Android filter file for ipc_tests. (Closed)

Created:
5 years, 5 months ago by tfarina
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez, jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Android filter file for ipc_tests. BUG=339980 TEST=ipc_tests R=jbudorick@chromium.org,tsepez@chromium.org Committed: https://crrev.com/8514f0dcbca6d27aab452662b6339aedd592e35e Cr-Commit-Position: refs/heads/master@{#340682}

Patch Set 1 #

Patch Set 2 : ChattyServer #

Patch Set 3 : DescriptorTest #

Patch Set 4 : #

Patch Set 5 : Times out #

Patch Set 6 : IPCFuzzingTest #

Patch Set 7 : IPCChannelTest #

Patch Set 8 : IPCChannelProxy + IPCChannelPosix #

Patch Set 9 : rm build/android/pylib/gtest/filter/ipc_tests_disabled #

Patch Set 10 : remaining tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -42 lines) Patch
M build/android/pylib/gtest/filter/ipc_tests_disabled View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -18 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 1 2 3 4 5 6 7 3 chunks +18 lines, -3 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 1 2 3 4 5 6 7 3 chunks +18 lines, -3 lines 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 2 3 4 5 6 7 8 9 3 chunks +13 lines, -3 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 1 2 3 4 5 6 7 8 9 4 chunks +24 lines, -4 lines 0 comments Download
M ipc/ipc_message_attachment_set_posix_unittest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +12 lines, -2 lines 0 comments Download
M ipc/ipc_message_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -1 line 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 2 3 4 5 6 7 8 9 5 chunks +32 lines, -5 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
tfarina
PTAL
5 years, 5 months ago (2015-07-25 02:45:19 UTC) #1
tfarina
This is ready for review, but looks like there are more tests to be disabled. ...
5 years, 5 months ago (2015-07-25 04:09:41 UTC) #2
Tom Sepez
looks good in principle once you get the remaining tests to pass.
5 years, 4 months ago (2015-07-27 15:46:59 UTC) #3
tfarina
This is ready for another look.
5 years, 4 months ago (2015-07-27 21:58:32 UTC) #4
Tom Sepez
lgtm
5 years, 4 months ago (2015-07-27 22:58:47 UTC) #5
jbudorick
build/android/ lgtm
5 years, 4 months ago (2015-07-27 22:59:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259823002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259823002/180001
5 years, 4 months ago (2015-07-28 14:14:09 UTC) #8
commit-bot: I haz the power
Committed patchset #10 (id:180001)
5 years, 4 months ago (2015-07-28 14:41:59 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 14:42:42 UTC) #10
Message was sent while issue was closed. 
Patchset 10 (id:??) landed as
https://crrev.com/8514f0dcbca6d27aab452662b6339aedd592e35e
Cr-Commit-Position: refs/heads/master@{#340682}

Powered by Google App Engine
This is Rietveld 408576698