Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1259803007: Make AnimatedStyleBuilder value rounding consistent with StyleBuilder (Closed)

Created:
5 years, 4 months ago by alancutter (OOO until 2018)
Modified:
5 years, 4 months ago
Reviewers:
dstockwell, Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make AnimatedStyleBuilder value rounding consistent with StyleBuilder For the following properties the StyleBuilder uses roundForImpreciseConversion() while the AnimatedStyleBuilder uses round(). - border-width - outline-width - -webkit-column-count - -webkit-column-rule-width This change updates AnimatedStyleBuilder to use rounding that is consistent with the StyleBuilder. BUG=437696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M LayoutTests/animations/interpolation/border-width-interpolation.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/outline-width-interpolation.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-column-count-interpolation.html View 2 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-column-rule-width-interpolation.html View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 10 chunks +16 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
alancutter (OOO until 2018)
5 years, 4 months ago (2015-08-03 05:48:38 UTC) #2
dstockwell
lgtm
5 years, 4 months ago (2015-08-13 07:56:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259803007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259803007/1
5 years, 4 months ago (2015-08-17 05:42:28 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 07:16:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200629

Powered by Google App Engine
This is Rietveld 408576698