Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: public/web/WebRuntimeFeatures.h

Issue 1259763006: Use std::string instead of WebString in WebRuntimeFeatures (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebRuntimeFeatures.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebRuntimeFeatures.h
diff --git a/public/web/WebRuntimeFeatures.h b/public/web/WebRuntimeFeatures.h
index 14175377dcab4dd9ccc8fdd3d9b63a14d1cbaedd..a3d58321368abcaf9c7e60704df8e8642d8808e1 100644
--- a/public/web/WebRuntimeFeatures.h
+++ b/public/web/WebRuntimeFeatures.h
@@ -34,6 +34,8 @@
#include "../platform/WebCommon.h"
#include "../platform/WebString.h"
+#include <string>
+
namespace blink {
// This class is used to enable runtime features of Blink.
@@ -48,6 +50,11 @@ public:
// Enables a feature by its string identifier from
// RuntimeEnabledFeatures.in.
+ // Note: We use std::string instead of WebString because this API can
+ // be called before blink::initalize(). We can't create WebString objects
+ // before blink::initialize().
+ BLINK_EXPORT static void enableFeatureFromString(const std::string& name, bool enable);
+ // TODO(bashi): Remove.
BLINK_EXPORT static void enableFeatureFromString(const WebString& name, bool enable);
BLINK_EXPORT static void enableApplicationCache(bool);
« no previous file with comments | « Source/web/WebRuntimeFeatures.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698