Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1259763006: Use std::string instead of WebString in WebRuntimeFeatures (Closed)

Created:
5 years, 4 months ago by bashi
Modified:
5 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, tasak
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use std::string instead of WebString in WebRuntimeFeatures The reason why I want to make this change comes from following facts: - WebString's internal implementation is String, and String uses PartitionAlloc to acquire memory. - PartitonAlloc must be initialized before any memory allocation. blink::initalize() does the job. - On the other hand, runtime features needs to be enabled/disabled before blink::initalize() because Blink's initialization logic depends on the configuration. WebRuntimeFeature provides APIs to enable/disable features and it depends on WebString. Conflict happens. By using std::string instead of WebString, we can avoid this problem because std::string doesn't depend on PartitionAlloc. We could take other options to fix this problem. For example, we can separate initialization into 2 phases. I didn't take this approach because it makes Blink API use be complicated. BUG=501171 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199972

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M Source/build/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl View 2 chunks +18 lines, -3 lines 0 comments Download
M Source/build/scripts/templates/RuntimeEnabledFeatures.h.tmpl View 2 chunks +3 lines, -1 line 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M public/web/WebRuntimeFeatures.h View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
bashi
Hi API owners, What do you think about this change? I want to fix http://crbug.com/501171 ...
5 years, 4 months ago (2015-07-31 06:40:22 UTC) #3
jochen (gone - plz use gerrit)
looks reasonable
5 years, 4 months ago (2015-07-31 07:04:52 UTC) #4
tkent
sounds reasonable to me too.
5 years, 4 months ago (2015-07-31 08:20:44 UTC) #5
haraken
non-owner LGTM
5 years, 4 months ago (2015-08-04 00:15:54 UTC) #6
tkent
Looks no one objects this. lgtm.
5 years, 4 months ago (2015-08-04 00:18:58 UTC) #7
bashi
On 2015/08/04 00:18:58, tkent wrote: > Looks no one objects this. lgtm. Landed https://codereview.chromium.org/1269793007/ as ...
5 years, 4 months ago (2015-08-04 09:22:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259763006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259763006/20001
5 years, 4 months ago (2015-08-04 10:18:59 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 11:37:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199972

Powered by Google App Engine
This is Rietveld 408576698