Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1259763004: Clean up some typos in GN quick start page. (Closed)

Created:
5 years, 4 months ago by Bons
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, brettw, Nico
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some typos in GN quick start page. Also adjust the sample code a bit. BUG=none Committed: https://crrev.com/19c81c689ac484b960dcbfb8633e1723245e5810 Cr-Commit-Position: refs/heads/master@{#341213}

Patch Set 1 #

Patch Set 2 : remove tutorial file #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tools/gn/docs/quick_start.md View 5 chunks +7 lines, -7 lines 0 comments Download
M tools/gn/tutorial/say_hello.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 14 (7 generated)
Bons
5 years, 4 months ago (2015-07-30 22:10:16 UTC) #3
Bons
+brettw
5 years, 4 months ago (2015-07-30 22:19:05 UTC) #6
Dirk Pranke
lgtm
5 years, 4 months ago (2015-07-30 22:26:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259763004/20001
5 years, 4 months ago (2015-07-30 22:27:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 22:38:11 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/19c81c689ac484b960dcbfb8633e1723245e5810 Cr-Commit-Position: refs/heads/master@{#341213}
5 years, 4 months ago (2015-07-30 22:38:56 UTC) #12
Nico
5 years, 4 months ago (2015-07-30 22:42:51 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/1259763004/diff/20001/tools/gn/tutorial/say_h...
File tools/gn/tutorial/say_hello.cc (right):

https://codereview.chromium.org/1259763004/diff/20001/tools/gn/tutorial/say_h...
tools/gn/tutorial/say_hello.cc:9: Hello("Bill", "Joy");
lgtm++

Powered by Google App Engine
This is Rietveld 408576698