Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1259743005:
Delete (nearly) all the flaky pass lines from TestExpectations. (Closed)
DescriptionDelete (nearly) all the flaky pass lines from TestExpectations.
Now that we retry tests 3 times instead of once, it's unclear if
any of these flaky lines apply and there's no automated way to
figure it out. Delete the lines for now.
The added lines are for tests that have stopped being flaky
and become reliable failures. A followup patch will rebaseline them.
This leaves in any lines that have Slow, NeedsRebaseline or
NeedsManualRebaseline and any flakes that don't include a Pass.
BUG=517148
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200095
Patch Set 1 #Patch Set 2 : fix lines and merge to ToT #Patch Set 3 : get tests passing locally #Patch Set 4 : Update with try run results #Patch Set 5 : add bug numbers #
Total comments: 1
Patch Set 6 : merge to ToT #Patch Set 7 : merge to ToT #
Total comments: 1
Patch Set 8 : add a couple more lines #Patch Set 9 : add LinkStyle.html and merge to ToT #Patch Set 10 : add smil-leak-element-instances.svg #Patch Set 11 : add more flakes. merge to ToT #Patch Set 12 : merge to ToT #Patch Set 13 : add another flake #Messages
Total messages: 57 (28 generated)
The CQ bit was checked by ojan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
The CQ bit was unchecked by ojan@chromium.org
The CQ bit was checked by ojan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/20001
The CQ bit was checked by ojan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/65073)
The CQ bit was checked by ojan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/65141)
ojan@chromium.org changed reviewers: + eae@chromium.org
keishi/pkasting: FYI, there might be a little increased flakiness after this patch. We'll just need to add lines appropriately. https://codereview.chromium.org/1259743005/diff/80001/LayoutTests/TestExpecta... File LayoutTests/TestExpectations (left): https://codereview.chromium.org/1259743005/diff/80001/LayoutTests/TestExpecta... LayoutTests/TestExpectations:1054: crbug.com/419101 [ Win Debug ] http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.html [ NeedsManualRebaseline ] This has been marked NeedsManualRebaseline for over a year. In the meantime, it's started failing on all Win. So it's subsumed by a line added at the top.
The CQ bit was checked by ojan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/120001
https://codereview.chromium.org/1259743005/diff/120001/LayoutTests/TestExpect... File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1259743005/diff/120001/LayoutTests/TestExpect... LayoutTests/TestExpectations:185: crbug.com/490511 imported/web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/template-content-node-document.html [ Failure Timeout ] This was wrong. Like the other tests in this directory, it sometimes times out.
The CL also adds a bunch of new Failure lines (as mentioned in the CL description), any reason you not to make those needsrebaseline right away?
On 2015/08/05 at 18:38:56, eae wrote: > The CL also adds a bunch of new Failure lines (as mentioned in the CL description), any reason you not to make those needsrebaseline right away? Just trying to scope the changes into things we can reason about. This was already a pretty big change.
On 2015/08/05 at 18:41:45, ojan wrote: > On 2015/08/05 at 18:38:56, eae wrote: > > The CL also adds a bunch of new Failure lines (as mentioned in the CL description), any reason you not to make those needsrebaseline right away? > > Just trying to scope the changes into things we can reason about. This was already a pretty big change. e.g. if this patch causes rampant flakiness, then I won't do the needsrebaseline followup without understanding the flakiness better.
On 2015/08/05 18:43:08, ojan wrote: > On 2015/08/05 at 18:41:45, ojan wrote: > > On 2015/08/05 at 18:38:56, eae wrote: > > > The CL also adds a bunch of new Failure lines (as mentioned in the CL > description), any reason you not to make those needsrebaseline right away? > > > > Just trying to scope the changes into things we can reason about. This was > already a pretty big change. > > e.g. if this patch causes rampant flakiness, then I won't do the needsrebaseline > followup without understanding the flakiness better. OK, in that case why not hold off updating the lines for those tests entirely? Moving from flaky to always failing seems like an odd interim step. Either way, LGTM.
pkasting@chromium.org changed reviewers: + pkasting@chromium.org
What about commenting out these lines instead of deleting them? Then when we get new flakiness data we can uncomment and update the relevant lines where applicable. I suggest this so as not to lose the bug information for these lines.
The CQ bit was checked by ojan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/1259743005/#ps140001 (title: "add a couple more lines")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/140001
On 2015/08/05 at 19:40:58, pkasting wrote: > What about commenting out these lines instead of deleting them? There's a bunch of flakiness that's way outdated. I'd rather just have a one-time clean sweep. It's potentially a little bit more painful for a day or two, but I think it will help us move much faster towards getting this under control. > Then when we get new flakiness data we can uncomment and update the relevant lines where applicable. > > I suggest this so as not to lose the bug information for these lines. That's a good suggestion, but I don't think it will work in practice. People will add lines without looking to see if there's a commented out line already there. We will have the bug numbers still in the diff of the commit, so we can still add them in manually.
On 2015/08/05 20:42:40, ojan wrote: > On 2015/08/05 at 19:40:58, pkasting wrote: > > What about commenting out these lines instead of deleting them? > > There's a bunch of flakiness that's way outdated. I'd rather just have a > one-time clean sweep. It's potentially a little bit more painful for a day or > two, but I think it will help us move much faster towards getting this under > control. > > > Then when we get new flakiness data we can uncomment and update the relevant > lines where applicable. > > > > I suggest this so as not to lose the bug information for these lines. > > That's a good suggestion, but I don't think it will work in practice. People > will add lines without looking to see if there's a commented out line already > there. We will have the bug numbers still in the diff of the commit, so we can > still add them in manually. I'm assuming you're going to be the one re-adding the data, and you're going to be doing it within one or two days total. Given that, I don't see your concerns as a problem and I think deleting the lines altogether is actually more annoying, although if you're guaranteeing me that you will find pre-existing bugs for every flaky expectation that's re-added (assuming they exist), then do it however you want. Since I'm sheriff the next two days, I'm not going to be "adding lines without looking", so let's do things some way that doesn't result in a bunch of orphaned bugs.
On 2015/08/05 at 20:46:11, pkasting wrote: > On 2015/08/05 20:42:40, ojan wrote: > > On 2015/08/05 at 19:40:58, pkasting wrote: > > > What about commenting out these lines instead of deleting them? > > > > There's a bunch of flakiness that's way outdated. I'd rather just have a > > one-time clean sweep. It's potentially a little bit more painful for a day or > > two, but I think it will help us move much faster towards getting this under > > control. > > > > > Then when we get new flakiness data we can uncomment and update the relevant > > lines where applicable. > > > > > > I suggest this so as not to lose the bug information for these lines. > > > > That's a good suggestion, but I don't think it will work in practice. People > > will add lines without looking to see if there's a commented out line already > > there. We will have the bug numbers still in the diff of the commit, so we can > > still add them in manually. > > I'm assuming you're going to be the one re-adding the data, and you're going to be doing it within one or two days total. Given that, I don't see your concerns as a problem and I think deleting the lines altogether is actually more annoying, although if you're guaranteeing me that you will find pre-existing bugs for every flaky expectation that's re-added (assuming they exist), then do it however you want. I'll do my best. > Since I'm sheriff the next two days, I'm not going to be "adding lines without looking", so let's do things some way that doesn't result in a bunch of orphaned bugs. Once the dust settles (next week?), I intend to close all the bugs that are no longer relevant.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/7...)
The CQ bit was checked by ojan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/1259743005/#ps160001 (title: "add LinkStyle.html and merge to ToT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/160001
The CQ bit was checked by ojan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/1259743005/#ps180001 (title: "add smil-leak-element-instances.svg")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/180001
The CQ bit was checked by ojan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/1259743005/#ps200001 (title: "add more flakes. merge to ToT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/200001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file LayoutTests/TestExpectations Hunk #16 succeeded at 645 with fuzz 2. Hunk #17 FAILED at 662. Hunk #18 succeeded at 665 (offset -11 lines). Hunk #19 succeeded at 702 (offset -11 lines). Hunk #20 succeeded at 731 (offset -11 lines). Hunk #21 succeeded at 746 (offset -11 lines). Hunk #22 succeeded at 764 (offset -11 lines). Hunk #23 succeeded at 781 (offset -11 lines). Hunk #24 succeeded at 797 (offset -11 lines). Hunk #25 succeeded at 2004 (offset -11 lines). Hunk #26 succeeded at 2021 (offset -11 lines). Hunk #27 succeeded at 2050 (offset -11 lines). 1 out of 27 hunks FAILED -- saving rejects to file LayoutTests/TestExpectations.rej Patch: LayoutTests/TestExpectations Index: LayoutTests/TestExpectations diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations index 3e26db8af1855aa717cc20cdc11666175d3a42f7..46d3bf3b373b498bc9e0b62b080d4af5d4a00aaf 100644 --- a/LayoutTests/TestExpectations +++ b/LayoutTests/TestExpectations @@ -1,66 +1,133 @@ crbug.com/504613 paint/images/image-backgrounds-not-antialiased.html [ ImageOnlyFailure ] crbug.com/502531 fast/borders/border-antialiasing.html [ ImageOnlyFailure ] -crbug.com/474117 compositing/overflow/overflow-positioning.html [ ImageOnlyFailure Pass ] +crbug.com/227231 fast/events/keyboardevent-key.html [ Failure ] +crbug.com/227231 virtual/pointerevent/fast/events/keyboardevent-key.html [ Failure ] +crbug.com/227231 virtual/trustedeventsdefaultaction/fast/events/keyboardevent-key.html [ Failure ] +crbug.com/231910 fast/dom/vertical-scrollbar-in-rtl.html [ Failure ] +crbug.com/24182 crbug.com/271243 http/tests/misc/acid3.html [ Failure ] +crbug.com/248063 plugins/plugin-clip-subframe.html [ Failure ] +crbug.com/248938 virtual/threaded/transitions/cancel-and-start-new.html [ Failure ] +crbug.com/255714 [ Linux ] editing/execCommand/switch-list-type-with-orphaned-li.html [ Failure ] +crbug.com/265650 compositing/repaint/transform-style-change.html [ ImageOnlyFailure ] +crbug.com/282093 [ Mac ] svg/hixie/text/001.xml [ Failure ] +crbug.com/289002 http/tests/security/frame-loading-via-document-write.html [ Failure ] +crbug.com/306249 media/W3C/video/networkState/networkState_during_progress.html [ Failure ] +crbug.com/309184 crbug.com/303419 crbug.com/284782 http/tests/media/media-source/mediasource-duration.html [ Failure ] +crbug.com/310679 [ Mac ] fast/frames/frame-set-rotation-hit.html [ Failure ] +crbug.com/310679 [ Mac ] fast/frames/frame-set-scaling-hit.html [ ImageOnlyFailure ] +crbug.com/311301 fast/history/history_reload.html [ Failure ] +crbug.com/320139 fast/repaint/block-layout-inline-children-replaced.html [ Failure ] +crbug.com/338794 compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html [ Failure ] +crbug.com/338794 crbug.com/192172 compositing/rtl/rtl-iframe-absolute-overflow.html [ Failure ] +crbug.com/338794 crbug.com/192172 compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ Failure ] +crbug.com/338794 crbug.com/192172 compositing/rtl/rtl-iframe-fixed-overflow.html [ Failure ] +crbug.com/345646 fast/repaint/selection-after-remove.html [ Failure ] +crbug.com/345648 fast/repaint/selection-gap-overflow-scroll.html [ Failure ] +crbug.com/345649 fast/repaint/delete-into-nested-block.html [ Failure ] +crbug.com/345767 fast/repaint/selection-gap-overflow-scroll-2.html [ Failure ] +crbug.com/346151 crbug.com/24182 css3/filters/effect-reference-hidpi-hw.html [ ImageOnlyFailure ] +crbug.com/356834 fast/repaint/shift-relative-positioned-container-with-image-addition.html [ Failure ] +crbug.com/356997 http/tests/security/isolatedWorld/events.html [ Failure ] +crbug.com/357068 css3/images/cross-fade-invalidation.html [ ImageOnlyFailure ] +crbug.com/359960 compositing/iframes/scrolling-iframe.html [ Failure ] +crbug.com/362434 [ Mac ] virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html [ ImageOnlyFailure ] +crbug.com/374572 svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html [ ImageOnlyFailure ] +crbug.com/375565 [ Mac ] fast/repaint/caret-with-transformation.html [ Failure ] +crbug.com/376597 web-animations-api/player.html [ Failure ] +crbug.com/377660 svg/custom/repaint-moving-svg-and-div.xhtml [ Failure ] +crbug.com/377950 svg/repaint/image-animation-with-zoom.html [ Failure ] +crbug.com/377950 virtual/gpu/fast/canvas/canvas-scale-drawImage-shadow.html [ Failure ] +crbug.com/390452 http/tests/security/isolatedWorld/media-query-wrapper-leaks.html [ Failure ] +crbug.com/399430 crbug.com/509025 crbug.com/133097 [ Mac ] fast/transforms/transformed-focused-text-input.html [ ImageOnlyFailure ] +crbug.com/409534 compositing/overflow/do-not-crash-use-after-free-update-widget-positions.html [ Failure ] +crbug.com/409534 virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-crash-use-after-free-update-widget-positions.html [ Failure ] +crbug.com/410145 [ Win ] fast/text/justify-ideograph-vertical.html [ ImageOnlyFailure ] +crbug.com/410145 [ Win ] fast/text/orientation-sideways.html [ ImageOnlyFailure ] +crbug.com/410145 crbug.com/453002 [ Win ] fast/writing-mode/english-lr-text.html [ ImageOnlyFailure ] +crbug.com/417174 compositing/scaling/tiled-layer-recursion.html [ ImageOnlyFailure ] +crbug.com/417782 [ Linux Win ] virtual/rootlayerscrolls/fast/scrolling/fractional-scroll-offset-fixed-position-non-composited.html [ ImageOnlyFailure ] +crbug.com/419101 crbug.com/357075 [ Win ] http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.html [ Failure ] +crbug.com/419486 [ Mac ] fast/text/atsui-small-caps-punctuation-size.html [ ImageOnlyFailure ] +crbug.com/421283 [ Mac ] fast/html/marquee-scrollamount.html [ Failure ] +crbug.com/432129 [ Mac ] fast/html/marquee-scroll.html [ Failure ] +crbug.com/447425 [ Mac ] fast/dynamic/011.html [ Failure ] +crbug.com/449023 http/tests/security/mixedContent/insecure-image-in-main-frame-blocked.html [ Failure ] +crbug.com/449242 [ Linux ] fast/css/word-spacing-characters-complex-text.html [ ImageOnlyFailure ] +crbug.com/450493 crbug.com/442730 inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html [ Failure ] +crbug.com/452967 [ Mac ] svg/batik/text/xmlSpace.svg [ Failure ] +crbug.com/453002 crbug.com/410145 [ Win ] fast/css/font-weight-1.html [ ImageOnlyFailure ] +crbug.com/460580 [ Mac ] tables/mozilla/bugs/bug2479-2.html [ ImageOnlyFailure ] +crbug.com/461107 crbug.com/450706 [ Win ] virtual/gpu/fast/canvas/canvas-composite-video.html [ ImageOnlyFailure ] +crbug.com/475244 media/video-durationchange-on-ended.html [ Failure ] +crbug.com/488101 fast/loader/unload-form-post-about-blank.html [ Failure ] +crbug.com/489548 fast/events/stop-load-in-unload-handler-using-window-stop.html [ Failure ] +crbug.com/489548 virtual/pointerevent/fast/events/stop-load-in-unload-handler-using-window-stop.html [ Failure ] +crbug.com/489548 virtual/trustedeventsdefaultaction/fast/events/stop-load-in-unload-handler-using-window-stop.html [ Failure ] +crbug.com/492664 [ Linux XP ] imported/csswg-test/css-writing-modes-3/box-offsets-rel-pos-vlr-005.xht [ ImageOnlyFailure ] +crbug.com/492664 [ Linux XP ] imported/csswg-test/css-writing-modes-3/box-offsets-rel-pos-vrl-004.xht [ ImageOnlyFailure ] +crbug.com/492664 [ Mac ] imported/csswg-test/css-writing-modes-3/bidi-embed-002.html [ ImageOnlyFailure ] +crbug.com/492664 [ Mac ] imported/csswg-test/css-writing-modes-3/bidi-isolate-002.html [ ImageOnlyFailure ] +crbug.com/492664 [ Win ] imported/csswg-test/css-writing-modes-3/bidi-override-005.html [ ImageOnlyFailure ] +crbug.com/492664 [ Win ] imported/csswg-test/css-writing-modes-3/bidi-plaintext-001.html [ ImageOnlyFailure ] +crbug.com/492664 imported/csswg-test/css-writing-modes-3/text-combine-upright-value-all-001.html [ ImageOnlyFailure ] +crbug.com/492664 imported/csswg-test/css-writing-modes-3/text-combine-upright-value-all-002.html [ ImageOnlyFailure ] +crbug.com/492664 imported/csswg-test/css-writing-modes-3/text-combine-upright-value-all-003.html [ ImageOnlyFailure ] +crbug.com/505795 [ Mac Win ] fast/text/emphasis-ellipsis-complextext.html [ ImageOnlyFailure ] +crbug.com/509025 crbug.com/410145 [ Win ] fast/text/international/vertical-text-glyph-test.html [ ImageOnlyFailure ] + +crbug.com/267206 [ Mac ] virtual/rootlayerscrolls/fast/scrolling/scrollbar-tickmarks-hittest.html [ Timeout ] +crbug.com/490511 imported/web-platform-tests/html/semantics/embedded-content/media-elements/playing-the-media-resource/pause-remove-from-document-networkState.html [ Timeout ] + +crbug.com/248938 virtual/threaded/animations/change-keyframes-name.html [ Failure Pass ] +crbug.com/248938 virtual/threaded/animations/change-one-anim.html [ Failure Pass ] +crbug.com/248938 virtual/threaded/animations/combo-transform-translate+scale.html [ Failure Pass ] +crbug.com/326139 crbug.com/390125 media/video-frame-accurate-seek.html [ ImageOnlyFailure Pass ] +crbug.com/352856 [ Mac ] svg/batik/text/textPosition.svg [ Failure Pass ] +crbug.com/352856 [ Mac ] svg/batik/text/textPosition2.svg [ Failure Pass ] +crbug.com/392640 svg/as-object/sizing/svg-in-object-placeholder-height-auto.html [ Timeout Pass ] +crbug.com/413604 http/tests/loading/script-priorities.html [ Failure Pass ] +crbug.com/455111 [ Win ] fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html [ Failure Pass ] +crbug.com/455111 [ Win ] fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html [ Failure Pass ] +crbug.com/479181 inspector-protocol/animation/animation-multiple-frames.html [ Failure Pass ] +crbug.com/479202 fast/forms/select/select-typeahead-with-spacekey.html [ Failure Pass ] +crbug.com/490511 imported/web-platform-tests/html/semantics/document-metadata/styling/LinkStyle.html [ Failure Pass ] +crbug.com/4… (message too large)
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by ojan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/1259743005/#ps220001 (title: "merge to ToT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/220001
The CQ bit was checked by ojan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/1259743005/#ps240001 (title: "add another flake")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/240001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/72753)
The CQ bit was checked by ojan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259743005/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259743005/240001
Message was sent while issue was closed.
Committed patchset #13 (id:240001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200095 |
