runtime/vm/intermediate_language_arm.cc - Issue 1259713005: Save a few register moves in function prolog on arm64 by using the same pattern

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 1259713005: Save a few register moves in function prolog on arm64 by using the same pattern (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_arm.cc

diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc

index 3ad7cc009cae29f2f52d4e52ff412cd718435747..f04a38253b3e0e5c2070323dd06005ecb79d3380 100644

--- a/runtime/vm/intermediate_language_arm.cc

+++ b/runtime/vm/intermediate_language_arm.cc

@@ -104,6 +104,7 @@ void ReturnInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

__ bkpt(0);

__ Bind(&stack_ok);

#endif

+ ASSERT(__ constant_pool_allowed());

__ LeaveDartFrame(); // Disallows constant pool use.

__ Ret();

// This ReturnInstr may be emitted out of order by the optimizer. The next

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »