Issue 1259693003: Make V8 compile with MSVS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1259693003: Make V8 compile with MSVS 2015 (Closed)

Created:
5 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 4 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Make V8 compile with MSVS 2015 BUG=v8:4326 R=machenbach@chromium.org LOG=y Committed: https://crrev.com/2714ee553933523d50abdc44897d9df3203c39fe Cr-Commit-Position: refs/heads/master@{#29868}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -1 line)			Patch
	M	build/standalone.gypi	View		1 chunk	+79 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

lgtm, but note that there's no coverage on the bots yet

5 years, 4 months ago (2015-07-27 11:39:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259693003/1

5 years, 4 months ago (2015-07-27 11:39:41 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-07-27 11:51:30 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2714ee553933523d50abdc44897d9df3203c39fe
Cr-Commit-Position: refs/heads/master@{#29868}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages