Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: chrome/android/java/res/layout/main.xml

Issue 1259683004: Gray top border for keyboard accessory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@keyboard-accessory
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/main.xml
diff --git a/chrome/android/java/res/layout/main.xml b/chrome/android/java/res/layout/main.xml
index fbf478e2eaba53ca0dd7824d5931a2cbe369a84e..035840507f2204cedd369ef43f380d3ff01652c0 100644
--- a/chrome/android/java/res/layout/main.xml
+++ b/chrome/android/java/res/layout/main.xml
@@ -9,11 +9,25 @@
android:layout_height="match_parent"
android:orientation="vertical">
- <org.chromium.chrome.browser.compositor.CompositorViewHolder
- android:id="@+id/compositor_view_holder"
- android:layout_width="match_parent"
+ <RelativeLayout
newt (away) 2015/08/06 03:27:22 No more nesting :O We've already introduced one n
please use gerrit instead 2015/08/07 18:43:28 I've placed the shadow inside of the keyboard acce
android:layout_height="0dp"
- android:layout_weight="1" />
+ android:layout_weight="1"
+ android:layout_width="match_parent">
+
+ <org.chromium.chrome.browser.compositor.CompositorViewHolder
+ android:id="@+id/compositor_view_holder"
+ android:layout_alignParentBottom="true"
+ android:layout_height="match_parent"
+ android:layout_width="match_parent" />
+
+ <View
+ android:id="@+id/keyboard_accessory_shadow"
+ android:layout_alignParentBottom="true"
+ android:layout_height="2dp"
+ android:layout_width="match_parent"
+ android:background="@drawable/keyboard_accessory_shadow"
+ android:visibility="gone" />
+ </RelativeLayout>
<HorizontalScrollView
android:id="@+id/keyboard_accessory"

Powered by Google App Engine
This is Rietveld 408576698