Gray top border for keyboard accessory.

Gray top border for keyboard accessory.

BUG=428087
Committed: https://crrev.com/bdb5954ac98ff4d3238814583670eaab820e5164
Cr-Commit-Position: refs/heads/master@{#344369}

[please use gerrit instead, 2015-08-05 20:51:42]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2015-08-05 20:54:24]

Patchset #1 (id:20001) has been deleted

[please use gerrit instead, 2015-08-05 20:55:52]

rouslan@chromium.org changed reviewers:
+ newt@chromium.org

[please use gerrit instead, 2015-08-05 20:55:52]

Newton, PTAL.

[please use gerrit instead, 2015-08-06 00:48:06]

See first screenshot @ http://crbug.com/428087#c23. (Second screenshot shows 6dp
shadow, which shows off the effect nicely, but UX wants 2dp.)

[newt (away), 2015-08-06 03:27:22]

https://codereview.chromium.org/1259683004/diff/40001/chrome/android/java/res...
File chrome/android/java/res/layout/main.xml (right):

https://codereview.chromium.org/1259683004/diff/40001/chrome/android/java/res...
chrome/android/java/res/layout/main.xml:12: <RelativeLayout
No more nesting :O

We've already introduced one new layer of nesting above the main View (which
slows down every input event, every layout, etc), let's avoid adding more if at
all possible.

Is it possible? Yes! If you simply give the keyboard_accessory a top margin of
-2dp, and then build the shadow into the keyboard_accessory view, that should
work nicely.

Also, there's a FadingShadowView, which may be handy here (It's specifically
designed for cases where the shadow needs to fade in a fade out, like on the
bottom of the new tab page, but it would work here too). It's currently in
chrome/ but can be moved to ui/. Using keyboard_accessory_shadow.xml is also
fine.

[please use gerrit instead, 2015-08-07 18:43:28]

Newton, please see my comment below.

https://codereview.chromium.org/1259683004/diff/40001/chrome/android/java/res...
File chrome/android/java/res/layout/main.xml (right):

https://codereview.chromium.org/1259683004/diff/40001/chrome/android/java/res...
chrome/android/java/res/layout/main.xml:12: <RelativeLayout
On 2015/08/06 03:27:22, newt wrote:
> No more nesting :O
> 
> We've already introduced one new layer of nesting above the main View (which
> slows down every input event, every layout, etc), let's avoid adding more if
at
> all possible.
> 
> Is it possible? Yes! If you simply give the keyboard_accessory a top margin of
> -2dp, and then build the shadow into the keyboard_accessory view, that should
> work nicely.
> 
> Also, there's a FadingShadowView, which may be handy here (It's specifically
> designed for cases where the shadow needs to fade in a fade out, like on the
> bottom of the new tab page, but it would work here too). It's currently in
> chrome/ but can be moved to ui/. Using keyboard_accessory_shadow.xml is also
> fine.

I've placed the shadow inside of the keyboard accessory and made it overlap
content by 2dp, which is the size of the shadow. However, this produces
artifacts as seen in

https://drive.google.com/a/google.com/file/d/0BwnAxYoFTeYPdl93WlVxT0dYYm8

It's as if the content is not redrawing under the shadow. Did I miss something
obvious?

[please use gerrit instead, 2015-08-19 21:57:32]

Newton, PTAL Patch Set 4.

Until I figure out how to draw a shadow, let's go with a 1dp #ADADAD border on
top of the keyboard accessory. Screenshot @ http://crbug.com/428087#c44.

[newt (away), 2015-08-19 22:25:26]

lgtm.

For the real shadow, it might be easiest to set the HorizontalScrollView's
background to a 9-patch, similar to what we do for the location bar background.

[please use gerrit instead, 2015-08-19 22:33:32]

On 2015/08/19 22:25:26, newt wrote:
> lgtm.
> 
> For the real shadow, it might be easiest to set the HorizontalScrollView's
> background to a 9-patch, similar to what we do for the location bar
background.

I wonder if it would be possible to flip location bar's background upside down
for the keyboard accessory...

By the way, the border turned out to be too dark. I'm changing it from #ADADAD
to #DDD.

[please use gerrit instead, 2015-08-19 22:42:47]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2015-08-19 22:42:48]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1259683004/#ps120001
(title: "#DDD color")

[commit-bot: I haz the power, 2015-08-19 22:43:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1259683004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1259683004/120001

[commit-bot: I haz the power, 2015-08-20 00:08:13]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2015-08-20 00:09:42]

Patchset 5 (id:??) landed as
https://crrev.com/bdb5954ac98ff4d3238814583670eaab820e5164
Cr-Commit-Position: refs/heads/master@{#344369}