content/renderer/service_worker/service_worker_type_util.cc - Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_type_util.cc

Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/service_worker_context_client.cc ('k') | content/renderer/speech_recognition_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_type_util.cc

diff --git a/content/renderer/service_worker/service_worker_type_util.cc b/content/renderer/service_worker/service_worker_type_util.cc

index 14df3a34c447575f03663790817aa08f30b50c8f..2a39659ba1329b63f28f6b5ccfacd5a9c0c2d118 100644

--- a/content/renderer/service_worker/service_worker_type_util.cc

+++ b/content/renderer/service_worker/service_worker_type_util.cc

@@ -25,8 +25,10 @@ class HeaderVisitor : public blink::WebHTTPHeaderVisitor {

virtual void visitHeader(const blink::WebString& name,

const blink::WebString& value) {

- const std::string header_name = base::UTF16ToASCII(name);

- const std::string header_value = base::UTF16ToASCII(value);

+ const std::string header_name =

+ base::UTF16ToASCII(base::StringPiece16(name));

+ const std::string header_value =

+ base::UTF16ToASCII(base::StringPiece16(value));

CHECK(header_name.find('\0') == std::string::npos);

CHECK(header_value.find('\0') == std::string::npos);

headers_->insert(ServiceWorkerHeaderMap::value_type(