content/renderer/render_view_impl.cc - Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index f4b178281a5203d1b7a575bcd09aa32a25cfb102..eda9e4eb86afab951fb9cbae9f9c1454e52c55d9 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1603,7 +1603,7 @@ WebView* RenderViewImpl::createView(WebLocalFrame* creator,

params.window_container_type = WindowFeaturesToContainerType(features);

params.session_storage_namespace_id = session_storage_namespace_id_;

if (frame_name != "_blank")

- params.frame_name = base::UTF16ToUTF8(frame_name);

+ params.frame_name = base::UTF16ToUTF8(base::StringPiece16(frame_name));

params.opener_render_frame_id =

RenderFrameImpl::FromWebFrame(creator)->GetRoutingID();

params.opener_url = creator->document().url();

« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | content/renderer/renderer_blink_platform_impl.cc » ('j') | no next file with comments »