content/child/notifications/notification_data_conversions.cc - Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/notifications/notification_data_conversions.cc

Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/notifications/notification_data_conversions.cc

diff --git a/content/child/notifications/notification_data_conversions.cc b/content/child/notifications/notification_data_conversions.cc

index f5fe5bb12ef66dc5d88bc5fef957d9096fe03bf1..c1eaec04c634af648a0643ea7670118a8ca17392 100644

--- a/content/child/notifications/notification_data_conversions.cc

+++ b/content/child/notifications/notification_data_conversions.cc

@@ -20,9 +20,9 @@ PlatformNotificationData ToPlatformNotificationData(

web_data.direction == WebNotificationData::DirectionLeftToRight

? PlatformNotificationData::NotificationDirectionLeftToRight

: PlatformNotificationData::NotificationDirectionRightToLeft;

- platform_data.lang = base::UTF16ToUTF8(web_data.lang);

+ platform_data.lang = base::UTF16ToUTF8(base::StringPiece16(web_data.lang));

platform_data.body = web_data.body;

- platform_data.tag = base::UTF16ToUTF8(web_data.tag);

+ platform_data.tag = base::UTF16ToUTF8(base::StringPiece16(web_data.tag));

platform_data.icon = GURL(web_data.icon.string());

platform_data.vibration_pattern.assign(web_data.vibrate.begin(),

web_data.vibrate.end());

« no previous file with comments | « content/child/browser_font_resource_trusted.cc ('k') | content/child/notifications/notification_manager.cc » ('j') | no next file with comments »